* [patch, BK] clean up and unify asm-*/resource.h files
@ 2005-02-09 9:39 Ingo Molnar
2005-02-09 15:03 ` Stephen Rothwell
0 siblings, 1 reply; 7+ messages in thread
From: Ingo Molnar @ 2005-02-09 9:39 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel, David S. Miller, chris
this patch does the final consolidation of asm-*/resource.h file,
without changing any of the rlimit definitions on any architecture.
Primarily it removes the __ARCH_RLIMIT_ORDER method and replaces it with
a more compact and isolated one that allows architectures to define only
the offending rlimits.
This method has the positive effect that adding a new rlimit can now be
purely done via changing asm-generic/resource.h alone. Previously one
would have to patch 4 other (sparc, sparc64, alpha and mips) resource.h
files.
the patch also does style unification, whitespace cleanups and
simplification of resource.h files and cleans up the
asm-generic/resource.h file as well. I've added more comments too.
this patch should have no effect on any code on any architecture. (i.e.
it's a pure identity patch.)
Tested on x86 and carefully reviewed to make sure that Sparc, Sparc64,
MIPS and Alpha rlimits are still the same as required by the ABI.
Signed-off-by: Ingo Molnar <mingo@elte.hu>
--- linux/include/asm-sparc/resource.h.orig
+++ linux/include/asm-sparc/resource.h
@@ -8,32 +8,18 @@
#define _SPARC_RESOURCE_H
/*
- * Resource limits
+ * These two resource limit IDs have a Sparc/Linux-specific ordering,
+ * the rest comes from the generic header:
*/
-
-#define RLIMIT_CPU 0 /* CPU time in ms */
-#define RLIMIT_FSIZE 1 /* Maximum filesize */
-#define RLIMIT_DATA 2 /* max data size */
-#define RLIMIT_STACK 3 /* max stack size */
-#define RLIMIT_CORE 4 /* max core file size */
-#define RLIMIT_RSS 5 /* max resident set size */
-#define RLIMIT_NOFILE 6 /* max number of open files */
-#define RLIMIT_NPROC 7 /* max number of processes */
-#define RLIMIT_MEMLOCK 8 /* max locked-in-memory address space */
-#define RLIMIT_AS 9 /* address space limit */
-#define RLIMIT_LOCKS 10 /* maximum file locks held */
-#define RLIMIT_SIGPENDING 11 /* max number of pending signals */
-#define RLIMIT_MSGQUEUE 12 /* maximum bytes in POSIX mqueues */
-
-#define RLIM_NLIMITS 13
-#define __ARCH_RLIMIT_ORDER
+#define RLIMIT_NPROC 6 /* max number of processes */
+#define RLIMIT_NOFILE 7 /* max number of open files */
/*
* SuS says limits have to be unsigned.
* We make this unsigned, but keep the
- * old value.
+ * old value for compatibility:
*/
-#define RLIM_INFINITY 0x7fffffff
+#define RLIM_INFINITY 0x7fffffff
#include <asm-generic/resource.h>
--- linux/include/asm-alpha/resource.h.orig
+++ linux/include/asm-alpha/resource.h
@@ -2,32 +2,20 @@
#define _ALPHA_RESOURCE_H
/*
- * Resource limits
+ * Alpha/Linux-specific ordering of these four resource limit IDs,
+ * the rest comes from the generic header:
*/
-
-#define RLIMIT_CPU 0 /* CPU time in ms */
-#define RLIMIT_FSIZE 1 /* Maximum filesize */
-#define RLIMIT_DATA 2 /* max data size */
-#define RLIMIT_STACK 3 /* max stack size */
-#define RLIMIT_CORE 4 /* max core file size */
-#define RLIMIT_RSS 5 /* max resident set size */
-#define RLIMIT_NOFILE 6 /* max number of open files */
-#define RLIMIT_AS 7 /* address space limit(?) */
-#define RLIMIT_NPROC 8 /* max number of processes */
-#define RLIMIT_MEMLOCK 9 /* max locked-in-memory address space */
-#define RLIMIT_LOCKS 10 /* maximum file locks held */
-#define RLIMIT_SIGPENDING 11 /* max number of pending signals */
-#define RLIMIT_MSGQUEUE 12 /* maximum bytes in POSIX mqueues */
-
-#define RLIM_NLIMITS 13
-#define __ARCH_RLIMIT_ORDER
+#define RLIMIT_NOFILE 6 /* max number of open files */
+#define RLIMIT_AS 7 /* address space limit */
+#define RLIMIT_NPROC 8 /* max number of processes */
+#define RLIMIT_MEMLOCK 9 /* max locked-in-memory address space */
/*
* SuS says limits have to be unsigned. Fine, it's unsigned, but
* we retain the old value for compatibility, especially with DU.
* When you run into the 2^63 barrier, you call me.
*/
-#define RLIM_INFINITY 0x7ffffffffffffffful
+#define RLIM_INFINITY 0x7ffffffffffffffful
#include <asm-generic/resource.h>
--- linux/include/asm-generic/resource.h.orig
+++ linux/include/asm-generic/resource.h
@@ -2,57 +2,85 @@
#define _ASM_GENERIC_RESOURCE_H
/*
- * Resource limits
+ * Resource limit IDs
+ *
+ * ( Compatibility detail: there are architectures that have
+ * a different rlimit ID order in the 5-9 range and want
+ * to keep that order for binary compatibility. The reasons
+ * are historic and all new rlimits are identical across all
+ * arches. If an arch has such special order for some rlimits
+ * then it defines them prior including asm-generic/resource.h. )
*/
-/* Allow arch to control resource order */
-#ifndef __ARCH_RLIMIT_ORDER
#define RLIMIT_CPU 0 /* CPU time in ms */
#define RLIMIT_FSIZE 1 /* Maximum filesize */
#define RLIMIT_DATA 2 /* max data size */
#define RLIMIT_STACK 3 /* max stack size */
#define RLIMIT_CORE 4 /* max core file size */
-#define RLIMIT_RSS 5 /* max resident set size */
-#define RLIMIT_NPROC 6 /* max number of processes */
-#define RLIMIT_NOFILE 7 /* max number of open files */
-#define RLIMIT_MEMLOCK 8 /* max locked-in-memory address space */
-#define RLIMIT_AS 9 /* address space limit */
+
+#ifndef RLIMIT_RSS
+# define RLIMIT_RSS 5 /* max resident set size */
+#endif
+
+#ifndef RLIMIT_NPROC
+# define RLIMIT_NPROC 6 /* max number of processes */
+#endif
+
+#ifndef RLIMIT_NOFILE
+# define RLIMIT_NOFILE 7 /* max number of open files */
+#endif
+
+#ifndef RLIMIT_MEMLOCK
+# define RLIMIT_MEMLOCK 8 /* max locked-in-memory address space */
+#endif
+
+#ifndef RLIMIT_AS
+# define RLIMIT_AS 9 /* address space limit */
+#endif
+
#define RLIMIT_LOCKS 10 /* maximum file locks held */
#define RLIMIT_SIGPENDING 11 /* max number of pending signals */
#define RLIMIT_MSGQUEUE 12 /* maximum bytes in POSIX mqueues */
#define RLIM_NLIMITS 13
-#endif
/*
* SuS says limits have to be unsigned.
* Which makes a ton more sense anyway.
+ *
+ * Some architectures override this (for compatibility reasons):
*/
#ifndef RLIM_INFINITY
-#define RLIM_INFINITY (~0UL)
+# define RLIM_INFINITY (~0UL)
#endif
+/*
+ * RLIMIT_STACK default maximum - some architectures override it:
+ */
#ifndef _STK_LIM_MAX
-#define _STK_LIM_MAX RLIM_INFINITY
+# define _STK_LIM_MAX RLIM_INFINITY
#endif
#ifdef __KERNEL__
+/*
+ * boot-time rlimit defaults for the init task:
+ */
#define INIT_RLIMITS \
{ \
- [RLIMIT_CPU] = { RLIM_INFINITY, RLIM_INFINITY }, \
- [RLIMIT_FSIZE] = { RLIM_INFINITY, RLIM_INFINITY }, \
- [RLIMIT_DATA] = { RLIM_INFINITY, RLIM_INFINITY }, \
- [RLIMIT_STACK] = { _STK_LIM, _STK_LIM_MAX }, \
- [RLIMIT_CORE] = { 0, RLIM_INFINITY }, \
- [RLIMIT_RSS] = { RLIM_INFINITY, RLIM_INFINITY }, \
- [RLIMIT_NPROC] = { 0, 0 }, \
- [RLIMIT_NOFILE] = { INR_OPEN, INR_OPEN }, \
- [RLIMIT_MEMLOCK] = { MLOCK_LIMIT, MLOCK_LIMIT }, \
- [RLIMIT_AS] = { RLIM_INFINITY, RLIM_INFINITY }, \
- [RLIMIT_LOCKS] = { RLIM_INFINITY, RLIM_INFINITY }, \
+ [RLIMIT_CPU] = { RLIM_INFINITY, RLIM_INFINITY }, \
+ [RLIMIT_FSIZE] = { RLIM_INFINITY, RLIM_INFINITY }, \
+ [RLIMIT_DATA] = { RLIM_INFINITY, RLIM_INFINITY }, \
+ [RLIMIT_STACK] = { _STK_LIM, _STK_LIM_MAX }, \
+ [RLIMIT_CORE] = { 0, RLIM_INFINITY }, \
+ [RLIMIT_RSS] = { RLIM_INFINITY, RLIM_INFINITY }, \
+ [RLIMIT_NPROC] = { 0, 0 }, \
+ [RLIMIT_NOFILE] = { INR_OPEN, INR_OPEN }, \
+ [RLIMIT_MEMLOCK] = { MLOCK_LIMIT, MLOCK_LIMIT }, \
+ [RLIMIT_AS] = { RLIM_INFINITY, RLIM_INFINITY }, \
+ [RLIMIT_LOCKS] = { RLIM_INFINITY, RLIM_INFINITY }, \
[RLIMIT_SIGPENDING] = { MAX_SIGPENDING, MAX_SIGPENDING }, \
- [RLIMIT_MSGQUEUE] = { MQ_BYTES_MAX, MQ_BYTES_MAX }, \
+ [RLIMIT_MSGQUEUE] = { MQ_BYTES_MAX, MQ_BYTES_MAX }, \
}
#endif /* __KERNEL__ */
--- linux/include/asm-sparc64/resource.h.orig
+++ linux/include/asm-sparc64/resource.h
@@ -8,25 +8,11 @@
#define _SPARC64_RESOURCE_H
/*
- * Resource limits
+ * These two resource limit IDs have a Sparc/Linux-specific ordering,
+ * the rest comes from the generic header:
*/
-
-#define RLIMIT_CPU 0 /* CPU time in ms */
-#define RLIMIT_FSIZE 1 /* Maximum filesize */
-#define RLIMIT_DATA 2 /* max data size */
-#define RLIMIT_STACK 3 /* max stack size */
-#define RLIMIT_CORE 4 /* max core file size */
-#define RLIMIT_RSS 5 /* max resident set size */
-#define RLIMIT_NOFILE 6 /* max number of open files */
-#define RLIMIT_NPROC 7 /* max number of processes */
-#define RLIMIT_MEMLOCK 8 /* max locked-in-memory address space */
-#define RLIMIT_AS 9 /* address space limit */
-#define RLIMIT_LOCKS 10 /* maximum file locks held */
-#define RLIMIT_SIGPENDING 11 /* max number of pending signals */
-#define RLIMIT_MSGQUEUE 12 /* maximum bytes in POSIX mqueues */
-
-#define RLIM_NLIMITS 13
-#define __ARCH_RLIMIT_ORDER
+#define RLIMIT_NOFILE 6 /* max number of open files */
+#define RLIMIT_NPROC 7 /* max number of processes */
#include <asm-generic/resource.h>
--- linux/include/asm-mips/resource.h.orig
+++ linux/include/asm-mips/resource.h
@@ -9,36 +9,26 @@
#ifndef _ASM_RESOURCE_H
#define _ASM_RESOURCE_H
+#include <linux/config.h>
+
/*
- * Resource limits
+ * These five resource limit IDs have a MIPS/Linux-specific ordering,
+ * the rest comes from the generic header:
*/
-#define RLIMIT_CPU 0 /* CPU time in ms */
-#define RLIMIT_FSIZE 1 /* Maximum filesize */
-#define RLIMIT_DATA 2 /* max data size */
-#define RLIMIT_STACK 3 /* max stack size */
-#define RLIMIT_CORE 4 /* max core file size */
-#define RLIMIT_NOFILE 5 /* max number of open files */
-#define RLIMIT_AS 6 /* mapped memory */
-#define RLIMIT_RSS 7 /* max resident set size */
-#define RLIMIT_NPROC 8 /* max number of processes */
-#define RLIMIT_MEMLOCK 9 /* max locked-in-memory address space */
-#define RLIMIT_LOCKS 10 /* maximum file locks held */
-#define RLIMIT_SIGPENDING 11 /* max number of pending signals */
-#define RLIMIT_MSGQUEUE 12 /* maximum bytes in POSIX mqueues */
-
-#define RLIM_NLIMITS 13 /* Number of limit flavors. */
-#define __ARCH_RLIMIT_ORDER
+#define RLIMIT_NOFILE 5 /* max number of open files */
+#define RLIMIT_AS 6 /* address space limit */
+#define RLIMIT_RSS 7 /* max resident set size */
+#define RLIMIT_NPROC 8 /* max number of processes */
+#define RLIMIT_MEMLOCK 9 /* max locked-in-memory address space */
/*
* SuS says limits have to be unsigned.
- * Which makes a ton more sense anyway.
+ * Which makes a ton more sense anyway,
+ * but we keep the old value on MIPS32,
+ * for compatibility:
*/
-#include <linux/config.h>
#ifdef CONFIG_MIPS32
-#define RLIM_INFINITY 0x7fffffffUL
-#endif
-#ifdef CONFIG_MIPS64
-#define RLIM_INFINITY (~0UL)
+# define RLIM_INFINITY 0x7fffffffUL
#endif
#include <asm-generic/resource.h>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [patch, BK] clean up and unify asm-*/resource.h files
2005-02-09 9:39 [patch, BK] clean up and unify asm-*/resource.h files Ingo Molnar
@ 2005-02-09 15:03 ` Stephen Rothwell
2005-02-09 18:02 ` Ingo Molnar
0 siblings, 1 reply; 7+ messages in thread
From: Stephen Rothwell @ 2005-02-09 15:03 UTC (permalink / raw)
To: Ingo Molnar; +Cc: akpm, linux-kernel, davem, chris
[-- Attachment #1: Type: text/plain, Size: 629 bytes --]
Hi Ingo,
On Wed, 9 Feb 2005 10:39:27 +0100 Ingo Molnar <mingo@elte.hu> wrote:
>
> --- linux/include/asm-sparc/resource.h.orig
> +++ linux/include/asm-sparc/resource.h
.
.
> -#define RLIMIT_NOFILE 6 /* max number of open files */
> -#define RLIMIT_NPROC 7 /* max number of processes */
.
.
> +#define RLIMIT_NPROC 6 /* max number of processes */
> +#define RLIMIT_NOFILE 7 /* max number of open files */
Is it too late at night, or should those be reversed to match the ones you
are removing (and the sparc64 ones)?
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [patch, BK] clean up and unify asm-*/resource.h files
2005-02-09 15:03 ` Stephen Rothwell
@ 2005-02-09 18:02 ` Ingo Molnar
2005-02-09 18:56 ` Chris Wright
2005-02-09 20:09 ` David S. Miller
0 siblings, 2 replies; 7+ messages in thread
From: Ingo Molnar @ 2005-02-09 18:02 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: akpm, linux-kernel, davem, chrisw
* Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi Ingo,
>
> On Wed, 9 Feb 2005 10:39:27 +0100 Ingo Molnar <mingo@elte.hu> wrote:
> >
> > --- linux/include/asm-sparc/resource.h.orig
> > +++ linux/include/asm-sparc/resource.h
> .
> .
> > -#define RLIMIT_NOFILE 6 /* max number of open files */
> > -#define RLIMIT_NPROC 7 /* max number of processes */
> .
> .
> > +#define RLIMIT_NPROC 6 /* max number of processes */
> > +#define RLIMIT_NOFILE 7 /* max number of open files */
>
> Is it too late at night, or should those be reversed to match the ones
> you are removing (and the sparc64 ones)?
you are right - the sparc32 ones i got mixed up. (sigh.) The sparc64
ones (and mips and alpha) seem correct though. New patch below.
Ingo
--
this patch does the final consolidation of asm-*/resource.h file,
without changing any of the rlimit definitions on any architecture.
Primarily it removes the __ARCH_RLIMIT_ORDER method and replaces it with
a more compact and isolated one that allows architectures to define only
the offending rlimits.
This method has the positive effect that adding a new rlimit can now be
purely done via changing asm-generic/resource.h alone. Previously one
would have to patch 4 other (sparc, sparc64, alpha and mips) resource.h
files.
the patch also does style unification, whitespace cleanups and
simplification of resource.h files and cleans up the
asm-generic/resource.h file as well. I've added more comments too.
this patch should have no effect on any code on any architecture. (i.e.
it's a pure identity patch.)
Tested on x86 and reviewed to make sure that Sparc, Sparc64, MIPS and
Alpha rlimits are still the same as required by the ABI.
Signed-off-by: Ingo Molnar <mingo@elte.hu>
--- linux/include/asm-sparc/resource.h.orig
+++ linux/include/asm-sparc/resource.h
@@ -8,32 +8,18 @@
#define _SPARC_RESOURCE_H
/*
- * Resource limits
+ * These two resource limit IDs have a Sparc/Linux-specific ordering,
+ * the rest comes from the generic header:
*/
-
-#define RLIMIT_CPU 0 /* CPU time in ms */
-#define RLIMIT_FSIZE 1 /* Maximum filesize */
-#define RLIMIT_DATA 2 /* max data size */
-#define RLIMIT_STACK 3 /* max stack size */
-#define RLIMIT_CORE 4 /* max core file size */
-#define RLIMIT_RSS 5 /* max resident set size */
-#define RLIMIT_NOFILE 6 /* max number of open files */
-#define RLIMIT_NPROC 7 /* max number of processes */
-#define RLIMIT_MEMLOCK 8 /* max locked-in-memory address space */
-#define RLIMIT_AS 9 /* address space limit */
-#define RLIMIT_LOCKS 10 /* maximum file locks held */
-#define RLIMIT_SIGPENDING 11 /* max number of pending signals */
-#define RLIMIT_MSGQUEUE 12 /* maximum bytes in POSIX mqueues */
-
-#define RLIM_NLIMITS 13
-#define __ARCH_RLIMIT_ORDER
+#define RLIMIT_NOFILE 6 /* max number of open files */
+#define RLIMIT_NPROC 7 /* max number of processes */
/*
* SuS says limits have to be unsigned.
* We make this unsigned, but keep the
- * old value.
+ * old value for compatibility:
*/
-#define RLIM_INFINITY 0x7fffffff
+#define RLIM_INFINITY 0x7fffffff
#include <asm-generic/resource.h>
--- linux/include/asm-alpha/resource.h.orig
+++ linux/include/asm-alpha/resource.h
@@ -2,32 +2,20 @@
#define _ALPHA_RESOURCE_H
/*
- * Resource limits
+ * Alpha/Linux-specific ordering of these four resource limit IDs,
+ * the rest comes from the generic header:
*/
-
-#define RLIMIT_CPU 0 /* CPU time in ms */
-#define RLIMIT_FSIZE 1 /* Maximum filesize */
-#define RLIMIT_DATA 2 /* max data size */
-#define RLIMIT_STACK 3 /* max stack size */
-#define RLIMIT_CORE 4 /* max core file size */
-#define RLIMIT_RSS 5 /* max resident set size */
-#define RLIMIT_NOFILE 6 /* max number of open files */
-#define RLIMIT_AS 7 /* address space limit(?) */
-#define RLIMIT_NPROC 8 /* max number of processes */
-#define RLIMIT_MEMLOCK 9 /* max locked-in-memory address space */
-#define RLIMIT_LOCKS 10 /* maximum file locks held */
-#define RLIMIT_SIGPENDING 11 /* max number of pending signals */
-#define RLIMIT_MSGQUEUE 12 /* maximum bytes in POSIX mqueues */
-
-#define RLIM_NLIMITS 13
-#define __ARCH_RLIMIT_ORDER
+#define RLIMIT_NOFILE 6 /* max number of open files */
+#define RLIMIT_AS 7 /* address space limit */
+#define RLIMIT_NPROC 8 /* max number of processes */
+#define RLIMIT_MEMLOCK 9 /* max locked-in-memory address space */
/*
* SuS says limits have to be unsigned. Fine, it's unsigned, but
* we retain the old value for compatibility, especially with DU.
* When you run into the 2^63 barrier, you call me.
*/
-#define RLIM_INFINITY 0x7ffffffffffffffful
+#define RLIM_INFINITY 0x7ffffffffffffffful
#include <asm-generic/resource.h>
--- linux/include/asm-generic/resource.h.orig
+++ linux/include/asm-generic/resource.h
@@ -2,57 +2,85 @@
#define _ASM_GENERIC_RESOURCE_H
/*
- * Resource limits
+ * Resource limit IDs
+ *
+ * ( Compatibility detail: there are architectures that have
+ * a different rlimit ID order in the 5-9 range and want
+ * to keep that order for binary compatibility. The reasons
+ * are historic and all new rlimits are identical across all
+ * arches. If an arch has such special order for some rlimits
+ * then it defines them prior including asm-generic/resource.h. )
*/
-/* Allow arch to control resource order */
-#ifndef __ARCH_RLIMIT_ORDER
#define RLIMIT_CPU 0 /* CPU time in ms */
#define RLIMIT_FSIZE 1 /* Maximum filesize */
#define RLIMIT_DATA 2 /* max data size */
#define RLIMIT_STACK 3 /* max stack size */
#define RLIMIT_CORE 4 /* max core file size */
-#define RLIMIT_RSS 5 /* max resident set size */
-#define RLIMIT_NPROC 6 /* max number of processes */
-#define RLIMIT_NOFILE 7 /* max number of open files */
-#define RLIMIT_MEMLOCK 8 /* max locked-in-memory address space */
-#define RLIMIT_AS 9 /* address space limit */
+
+#ifndef RLIMIT_RSS
+# define RLIMIT_RSS 5 /* max resident set size */
+#endif
+
+#ifndef RLIMIT_NPROC
+# define RLIMIT_NPROC 6 /* max number of processes */
+#endif
+
+#ifndef RLIMIT_NOFILE
+# define RLIMIT_NOFILE 7 /* max number of open files */
+#endif
+
+#ifndef RLIMIT_MEMLOCK
+# define RLIMIT_MEMLOCK 8 /* max locked-in-memory address space */
+#endif
+
+#ifndef RLIMIT_AS
+# define RLIMIT_AS 9 /* address space limit */
+#endif
+
#define RLIMIT_LOCKS 10 /* maximum file locks held */
#define RLIMIT_SIGPENDING 11 /* max number of pending signals */
#define RLIMIT_MSGQUEUE 12 /* maximum bytes in POSIX mqueues */
#define RLIM_NLIMITS 13
-#endif
/*
* SuS says limits have to be unsigned.
* Which makes a ton more sense anyway.
+ *
+ * Some architectures override this (for compatibility reasons):
*/
#ifndef RLIM_INFINITY
-#define RLIM_INFINITY (~0UL)
+# define RLIM_INFINITY (~0UL)
#endif
+/*
+ * RLIMIT_STACK default maximum - some architectures override it:
+ */
#ifndef _STK_LIM_MAX
-#define _STK_LIM_MAX RLIM_INFINITY
+# define _STK_LIM_MAX RLIM_INFINITY
#endif
#ifdef __KERNEL__
+/*
+ * boot-time rlimit defaults for the init task:
+ */
#define INIT_RLIMITS \
{ \
- [RLIMIT_CPU] = { RLIM_INFINITY, RLIM_INFINITY }, \
- [RLIMIT_FSIZE] = { RLIM_INFINITY, RLIM_INFINITY }, \
- [RLIMIT_DATA] = { RLIM_INFINITY, RLIM_INFINITY }, \
- [RLIMIT_STACK] = { _STK_LIM, _STK_LIM_MAX }, \
- [RLIMIT_CORE] = { 0, RLIM_INFINITY }, \
- [RLIMIT_RSS] = { RLIM_INFINITY, RLIM_INFINITY }, \
- [RLIMIT_NPROC] = { 0, 0 }, \
- [RLIMIT_NOFILE] = { INR_OPEN, INR_OPEN }, \
- [RLIMIT_MEMLOCK] = { MLOCK_LIMIT, MLOCK_LIMIT }, \
- [RLIMIT_AS] = { RLIM_INFINITY, RLIM_INFINITY }, \
- [RLIMIT_LOCKS] = { RLIM_INFINITY, RLIM_INFINITY }, \
+ [RLIMIT_CPU] = { RLIM_INFINITY, RLIM_INFINITY }, \
+ [RLIMIT_FSIZE] = { RLIM_INFINITY, RLIM_INFINITY }, \
+ [RLIMIT_DATA] = { RLIM_INFINITY, RLIM_INFINITY }, \
+ [RLIMIT_STACK] = { _STK_LIM, _STK_LIM_MAX }, \
+ [RLIMIT_CORE] = { 0, RLIM_INFINITY }, \
+ [RLIMIT_RSS] = { RLIM_INFINITY, RLIM_INFINITY }, \
+ [RLIMIT_NPROC] = { 0, 0 }, \
+ [RLIMIT_NOFILE] = { INR_OPEN, INR_OPEN }, \
+ [RLIMIT_MEMLOCK] = { MLOCK_LIMIT, MLOCK_LIMIT }, \
+ [RLIMIT_AS] = { RLIM_INFINITY, RLIM_INFINITY }, \
+ [RLIMIT_LOCKS] = { RLIM_INFINITY, RLIM_INFINITY }, \
[RLIMIT_SIGPENDING] = { MAX_SIGPENDING, MAX_SIGPENDING }, \
- [RLIMIT_MSGQUEUE] = { MQ_BYTES_MAX, MQ_BYTES_MAX }, \
+ [RLIMIT_MSGQUEUE] = { MQ_BYTES_MAX, MQ_BYTES_MAX }, \
}
#endif /* __KERNEL__ */
--- linux/include/asm-sparc64/resource.h.orig
+++ linux/include/asm-sparc64/resource.h
@@ -8,25 +8,11 @@
#define _SPARC64_RESOURCE_H
/*
- * Resource limits
+ * These two resource limit IDs have a Sparc/Linux-specific ordering,
+ * the rest comes from the generic header:
*/
-
-#define RLIMIT_CPU 0 /* CPU time in ms */
-#define RLIMIT_FSIZE 1 /* Maximum filesize */
-#define RLIMIT_DATA 2 /* max data size */
-#define RLIMIT_STACK 3 /* max stack size */
-#define RLIMIT_CORE 4 /* max core file size */
-#define RLIMIT_RSS 5 /* max resident set size */
-#define RLIMIT_NOFILE 6 /* max number of open files */
-#define RLIMIT_NPROC 7 /* max number of processes */
-#define RLIMIT_MEMLOCK 8 /* max locked-in-memory address space */
-#define RLIMIT_AS 9 /* address space limit */
-#define RLIMIT_LOCKS 10 /* maximum file locks held */
-#define RLIMIT_SIGPENDING 11 /* max number of pending signals */
-#define RLIMIT_MSGQUEUE 12 /* maximum bytes in POSIX mqueues */
-
-#define RLIM_NLIMITS 13
-#define __ARCH_RLIMIT_ORDER
+#define RLIMIT_NOFILE 6 /* max number of open files */
+#define RLIMIT_NPROC 7 /* max number of processes */
#include <asm-generic/resource.h>
--- linux/include/asm-mips/resource.h.orig
+++ linux/include/asm-mips/resource.h
@@ -9,36 +9,26 @@
#ifndef _ASM_RESOURCE_H
#define _ASM_RESOURCE_H
+#include <linux/config.h>
+
/*
- * Resource limits
+ * These five resource limit IDs have a MIPS/Linux-specific ordering,
+ * the rest comes from the generic header:
*/
-#define RLIMIT_CPU 0 /* CPU time in ms */
-#define RLIMIT_FSIZE 1 /* Maximum filesize */
-#define RLIMIT_DATA 2 /* max data size */
-#define RLIMIT_STACK 3 /* max stack size */
-#define RLIMIT_CORE 4 /* max core file size */
-#define RLIMIT_NOFILE 5 /* max number of open files */
-#define RLIMIT_AS 6 /* mapped memory */
-#define RLIMIT_RSS 7 /* max resident set size */
-#define RLIMIT_NPROC 8 /* max number of processes */
-#define RLIMIT_MEMLOCK 9 /* max locked-in-memory address space */
-#define RLIMIT_LOCKS 10 /* maximum file locks held */
-#define RLIMIT_SIGPENDING 11 /* max number of pending signals */
-#define RLIMIT_MSGQUEUE 12 /* maximum bytes in POSIX mqueues */
-
-#define RLIM_NLIMITS 13 /* Number of limit flavors. */
-#define __ARCH_RLIMIT_ORDER
+#define RLIMIT_NOFILE 5 /* max number of open files */
+#define RLIMIT_AS 6 /* address space limit */
+#define RLIMIT_RSS 7 /* max resident set size */
+#define RLIMIT_NPROC 8 /* max number of processes */
+#define RLIMIT_MEMLOCK 9 /* max locked-in-memory address space */
/*
* SuS says limits have to be unsigned.
- * Which makes a ton more sense anyway.
+ * Which makes a ton more sense anyway,
+ * but we keep the old value on MIPS32,
+ * for compatibility:
*/
-#include <linux/config.h>
#ifdef CONFIG_MIPS32
-#define RLIM_INFINITY 0x7fffffffUL
-#endif
-#ifdef CONFIG_MIPS64
-#define RLIM_INFINITY (~0UL)
+# define RLIM_INFINITY 0x7fffffffUL
#endif
#include <asm-generic/resource.h>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [patch, BK] clean up and unify asm-*/resource.h files
2005-02-09 18:02 ` Ingo Molnar
@ 2005-02-09 18:56 ` Chris Wright
2005-02-09 19:05 ` Ingo Molnar
2005-02-09 20:09 ` David S. Miller
1 sibling, 1 reply; 7+ messages in thread
From: Chris Wright @ 2005-02-09 18:56 UTC (permalink / raw)
To: Ingo Molnar; +Cc: Stephen Rothwell, akpm, linux-kernel, davem, chrisw
* Ingo Molnar (mingo@elte.hu) wrote:
> this patch does the final consolidation of asm-*/resource.h file,
> without changing any of the rlimit definitions on any architecture.
> Primarily it removes the __ARCH_RLIMIT_ORDER method and replaces it with
> a more compact and isolated one that allows architectures to define only
> the offending rlimits.
Heh, I did it this way first, then worried people might find it confusing
to only have a subset of the block overwritten I backed it down to
the __ARCH_RLIMIT_ORDER method. Anyway, I like this change.
Acked-by: Chris Wright <chrisw@osdl.org>
thanks,
-chris
--
Linux Security Modules http://lsm.immunix.org http://lsm.bkbits.net
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [patch, BK] clean up and unify asm-*/resource.h files
2005-02-09 18:56 ` Chris Wright
@ 2005-02-09 19:05 ` Ingo Molnar
2005-02-09 19:14 ` Chris Wright
0 siblings, 1 reply; 7+ messages in thread
From: Ingo Molnar @ 2005-02-09 19:05 UTC (permalink / raw)
To: Chris Wright; +Cc: Stephen Rothwell, akpm, linux-kernel, davem
* Chris Wright <chrisw@osdl.org> wrote:
> * Ingo Molnar (mingo@elte.hu) wrote:
> > this patch does the final consolidation of asm-*/resource.h file,
> > without changing any of the rlimit definitions on any architecture.
> > Primarily it removes the __ARCH_RLIMIT_ORDER method and replaces it with
> > a more compact and isolated one that allows architectures to define only
> > the offending rlimits.
>
> Heh, I did it this way first, then worried people might find it
> confusing to only have a subset of the block overwritten I backed it
> down to the __ARCH_RLIMIT_ORDER method. Anyway, I like this change.
>
> Acked-by: Chris Wright <chrisw@osdl.org>
the original reason i ended up doing this was when i introduced a new
rlimit and it needed changes in 5 include files. Now the new rlimit is
off the agenda but the cleanup remained :-)
Ingo
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [patch, BK] clean up and unify asm-*/resource.h files
2005-02-09 19:05 ` Ingo Molnar
@ 2005-02-09 19:14 ` Chris Wright
0 siblings, 0 replies; 7+ messages in thread
From: Chris Wright @ 2005-02-09 19:14 UTC (permalink / raw)
To: Ingo Molnar; +Cc: Chris Wright, Stephen Rothwell, akpm, linux-kernel, davem
* Ingo Molnar (mingo@elte.hu) wrote:
>
> * Chris Wright <chrisw@osdl.org> wrote:
>
> > * Ingo Molnar (mingo@elte.hu) wrote:
> > > this patch does the final consolidation of asm-*/resource.h file,
> > > without changing any of the rlimit definitions on any architecture.
> > > Primarily it removes the __ARCH_RLIMIT_ORDER method and replaces it with
> > > a more compact and isolated one that allows architectures to define only
> > > the offending rlimits.
> >
> > Heh, I did it this way first, then worried people might find it
> > confusing to only have a subset of the block overwritten I backed it
> > down to the __ARCH_RLIMIT_ORDER method. Anyway, I like this change.
> >
> > Acked-by: Chris Wright <chrisw@osdl.org>
>
> the original reason i ended up doing this was when i introduced a new
> rlimit and it needed changes in 5 include files. Now the new rlimit is
> off the agenda but the cleanup remained :-)
Hehehe, that's the same reason I did the last one ;-)
cheers,
-chris
--
Linux Security Modules http://lsm.immunix.org http://lsm.bkbits.net
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [patch, BK] clean up and unify asm-*/resource.h files
2005-02-09 18:02 ` Ingo Molnar
2005-02-09 18:56 ` Chris Wright
@ 2005-02-09 20:09 ` David S. Miller
1 sibling, 0 replies; 7+ messages in thread
From: David S. Miller @ 2005-02-09 20:09 UTC (permalink / raw)
To: Ingo Molnar; +Cc: sfr, akpm, linux-kernel, davem, chrisw
On Wed, 9 Feb 2005 19:02:19 +0100
Ingo Molnar <mingo@elte.hu> wrote:
> New patch below.
...
> this patch does the final consolidation of asm-*/resource.h file,
> without changing any of the rlimit definitions on any architecture.
I'm fine with this.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2005-02-09 20:18 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-02-09 9:39 [patch, BK] clean up and unify asm-*/resource.h files Ingo Molnar
2005-02-09 15:03 ` Stephen Rothwell
2005-02-09 18:02 ` Ingo Molnar
2005-02-09 18:56 ` Chris Wright
2005-02-09 19:05 ` Ingo Molnar
2005-02-09 19:14 ` Chris Wright
2005-02-09 20:09 ` David S. Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.