From: Adrian Bunk <bunk@stusta.de>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] [PATCH][20/26] include/linux/* - compile warning cleanup
Date: Thu, 10 Feb 2005 23:10:43 +0000 [thread overview]
Message-ID: <20050210231043.GI2958@stusta.de> (raw)
In-Reply-To: <420BEF83.21250.587255@localhost>
[-- Attachment #1: Type: text/plain, Size: 1364 bytes --]
On Thu, Feb 10, 2005 at 11:34:27PM +0200, Stephen Biggs wrote:
Content-Description: Mail message body
> Description: compile warning cleanup - give RCS id string "unused"
> attribute to silence compiler warning
>
> Signed-off-by: Stephen Biggs <yrgrknmxpzlk@gawab.com>
>
> diff -Nurdp -X dontdiff-osdl linux-2.6.11-rc3-mm-original/include/linux/ixjuser.h linux-2.6.11-rc3-mm/include/linux/ixjuser.h
> --- linux-2.6.11-rc3-mm-original/include/linux/ixjuser.h 2005-02-03 03:57:05.000000000 +0200
> +++ linux-2.6.11-rc3-mm/include/linux/ixjuser.h 2005-02-08 15:32:55.000000000 +0200
> @@ -42,7 +42,7 @@
> *
> *****************************************************************************/
>
> -static char ixjuser_h_rcsid[] = "$Id: ixjuser.h,v 4.1 2001/08/05 00:17:37 craigs Exp $";
> +static char __attribute__((__unused__)) ixjuser_h_rcsid[] = "$Id: ixjuser.h,v 4.1 2001/08/05 00:17:37 craigs Exp $";
>...
This outdated string should better be killed (together with the only
usage in ixj.c). If a driver and such a string is maintained it might
make sense, but in this case it's simply useless.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
prev parent reply other threads:[~2005-02-10 23:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-10 21:34 [KJ] [PATCH][20/26] include/linux/* - compile warning cleanup Stephen Biggs
2005-02-10 23:10 ` Adrian Bunk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050210231043.GI2958@stusta.de \
--to=bunk@stusta.de \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.