[KJ] [PATCH][20/26] include/linux/* - compile warning cleanup

[KJ] [PATCH][20/26] include/linux/* - compile warning cleanup

[Stephen Biggs]

[-- Attachment #1: Mail message body --]
[-- Type: text/plain, Size: 816 bytes --]

Description: compile warning cleanup - give RCS id string "unused" 
attribute to silence compiler warning

Signed-off-by: Stephen Biggs <yrgrknmxpzlk@gawab.com>

diff -Nurdp -X dontdiff-osdl linux-2.6.11-rc3-mm-original/include/linux/ixjuser.h linux-2.6.11-rc3-mm/include/linux/ixjuser.h
--- linux-2.6.11-rc3-mm-original/include/linux/ixjuser.h	2005-02-03 03:57:05.000000000 +0200
+++ linux-2.6.11-rc3-mm/include/linux/ixjuser.h	2005-02-08 15:32:55.000000000 +0200
@@ -42,7 +42,7 @@
  *
  *****************************************************************************/
 
-static char ixjuser_h_rcsid[] = "$Id: ixjuser.h,v 4.1 2001/08/05 00:17:37 craigs Exp $";
+static char  __attribute__((__unused__)) ixjuser_h_rcsid[] = "$Id: ixjuser.h,v 4.1 2001/08/05 00:17:37 craigs Exp $";
 
 #include <linux/telephony.h>
 




[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [KJ] [PATCH][20/26] include/linux/* - compile warning cleanup

[Adrian Bunk]

[-- Attachment #1: Type: text/plain, Size: 1364 bytes --]

On Thu, Feb 10, 2005 at 11:34:27PM +0200, Stephen Biggs wrote:
Content-Description: Mail message body
> Description: compile warning cleanup - give RCS id string "unused" 
> attribute to silence compiler warning
> 
> Signed-off-by: Stephen Biggs <yrgrknmxpzlk@gawab.com>
> 
> diff -Nurdp -X dontdiff-osdl linux-2.6.11-rc3-mm-original/include/linux/ixjuser.h linux-2.6.11-rc3-mm/include/linux/ixjuser.h
> --- linux-2.6.11-rc3-mm-original/include/linux/ixjuser.h	2005-02-03 03:57:05.000000000 +0200
> +++ linux-2.6.11-rc3-mm/include/linux/ixjuser.h	2005-02-08 15:32:55.000000000 +0200
> @@ -42,7 +42,7 @@
>   *
>   *****************************************************************************/
>  
> -static char ixjuser_h_rcsid[] = "$Id: ixjuser.h,v 4.1 2001/08/05 00:17:37 craigs Exp $";
> +static char  __attribute__((__unused__)) ixjuser_h_rcsid[] = "$Id: ixjuser.h,v 4.1 2001/08/05 00:17:37 craigs Exp $";
>...

This outdated string should better be killed (together with the only 
usage in ixj.c). If a driver and such a string is maintained it might 
make sense, but in this case it's simply useless.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors