* 2.4 too - was [2.6 PATCH] syntax errors by smp_{mb,rmb,wmb} on
@ 2005-02-11 10:36 Meelis Roos
2005-02-11 10:38 ` 2.4 too - was [2.6 PATCH] syntax errors by smp_{mb,rmb,wmb} on sparc32 William Lee Irwin III
2005-02-11 20:23 ` 2.4 too - was [2.6 PATCH] syntax errors by smp_{mb,rmb,wmb} on David S. Miller
0 siblings, 2 replies; 3+ messages in thread
From: Meelis Roos @ 2005-02-11 10:36 UTC (permalink / raw)
To: sparclinux
> Hi Melis,
> the same holds true for 2.4.29 @ line 124, 125, 126 in the system.h file. This ought to be the same problem, isn't it? I do not have a sparc32 system, but maybe you can check,
Yes, the same compilation problem is also present in current 2.4. Patch
is below, output from bk diffs -u and read into pine with ^R - does it
work this time?
=== include/asm-sparc/system.h 1.8 vs edited ==--- 1.8/include/asm-sparc/system.h 2003-12-14 07:50:29 +02:00
+++ edited/include/asm-sparc/system.h 2005-02-11 10:52:00 +02:00
@@ -295,11 +295,11 @@
#define wmb() mb()
#define set_mb(__var, __value) do { __var = __value; mb(); } while(0)
#define set_wmb(__var, __value) set_mb(__var, __value)
-#define smp_mb() __asm__ __volatile__("":::"memory");
-#define smp_rmb() __asm__ __volatile__("":::"memory");
-#define smp_wmb() __asm__ __volatile__("":::"memory");
+#define smp_mb() __asm__ __volatile__("":::"memory")
+#define smp_rmb() __asm__ __volatile__("":::"memory")
+#define smp_wmb() __asm__ __volatile__("":::"memory")
-#define nop() __asm__ __volatile__ ("nop");
+#define nop() __asm__ __volatile__ ("nop")
/* This has special calling conventions */
#ifndef CONFIG_SMP
--
Meelis Roos (mroos@linux.ee)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: 2.4 too - was [2.6 PATCH] syntax errors by smp_{mb,rmb,wmb} on sparc32
2005-02-11 10:36 2.4 too - was [2.6 PATCH] syntax errors by smp_{mb,rmb,wmb} on Meelis Roos
@ 2005-02-11 10:38 ` William Lee Irwin III
2005-02-11 20:23 ` 2.4 too - was [2.6 PATCH] syntax errors by smp_{mb,rmb,wmb} on David S. Miller
1 sibling, 0 replies; 3+ messages in thread
From: William Lee Irwin III @ 2005-02-11 10:38 UTC (permalink / raw)
To: sparclinux
On Fri, Feb 11, 2005 at 12:36:48PM +0200, Meelis Roos wrote:
> Yes, the same compilation problem is also present in current 2.4. Patch
> is below, output from bk diffs -u and read into pine with ^R - does it
> work this time?
Dave, you seem to be in a flurry of sparc32 activity; did you want to
handle the 2.4 parts, too?
-- wli
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: 2.4 too - was [2.6 PATCH] syntax errors by smp_{mb,rmb,wmb} on
2005-02-11 10:36 2.4 too - was [2.6 PATCH] syntax errors by smp_{mb,rmb,wmb} on Meelis Roos
2005-02-11 10:38 ` 2.4 too - was [2.6 PATCH] syntax errors by smp_{mb,rmb,wmb} on sparc32 William Lee Irwin III
@ 2005-02-11 20:23 ` David S. Miller
1 sibling, 0 replies; 3+ messages in thread
From: David S. Miller @ 2005-02-11 20:23 UTC (permalink / raw)
To: sparclinux
On Fri, 11 Feb 2005 02:38:38 -0800
William Lee Irwin III <wli@holomorphy.com> wrote:
> On Fri, Feb 11, 2005 at 12:36:48PM +0200, Meelis Roos wrote:
> > Yes, the same compilation problem is also present in current 2.4. Patch
> > is below, output from bk diffs -u and read into pine with ^R - does it
> > work this time?
>
> Dave, you seem to be in a flurry of sparc32 activity; did you want to
> handle the 2.4 parts, too?
yeah. in fact I got this one already, thanks
I just need to push it upstream.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-02-11 20:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-02-11 10:36 2.4 too - was [2.6 PATCH] syntax errors by smp_{mb,rmb,wmb} on Meelis Roos
2005-02-11 10:38 ` 2.4 too - was [2.6 PATCH] syntax errors by smp_{mb,rmb,wmb} on sparc32 William Lee Irwin III
2005-02-11 20:23 ` 2.4 too - was [2.6 PATCH] syntax errors by smp_{mb,rmb,wmb} on David S. Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.