All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] remove unneeded ext2 include from nfsd
@ 2005-02-13 15:52 Olaf Hering
  2005-02-14  9:31 ` Olaf Kirch
  0 siblings, 1 reply; 3+ messages in thread
From: Olaf Hering @ 2005-02-13 15:52 UTC (permalink / raw)
  To: Neil Brown, nfs


nfs3proc.c includes ext2 headers for some constants, strange.
vfs.c does the same, but doesnt use anything from this header.


Signed-off-by: Olaf Hering <olh@suse.de>

diff -purNx tags ../linux-2.6.11-rc4.orig/fs/nfsd/vfs.c ./fs/nfsd/vfs.c
--- ../linux-2.6.11-rc4.orig/fs/nfsd/vfs.c	2005-02-13 04:06:05.000000000 +0100
+++ ./fs/nfsd/vfs.c	2005-02-13 16:00:07.702972643 +0100
@@ -24,7 +24,6 @@
 #include <linux/file.h>
 #include <linux/mount.h>
 #include <linux/major.h>
-#include <linux/ext2_fs.h>
 #include <linux/proc_fs.h>
 #include <linux/stat.h>
 #include <linux/fcntl.h>


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] remove unneeded ext2 include from nfsd
  2005-02-13 15:52 [PATCH] remove unneeded ext2 include from nfsd Olaf Hering
@ 2005-02-14  9:31 ` Olaf Kirch
  2005-02-14  9:33   ` Olaf Hering
  0 siblings, 1 reply; 3+ messages in thread
From: Olaf Kirch @ 2005-02-14  9:31 UTC (permalink / raw)
  To: Olaf Hering; +Cc: Neil Brown, nfs

On Sun, Feb 13, 2005 at 04:52:57PM +0100, Olaf Hering wrote:
> nfs3proc.c includes ext2 headers for some constants, strange.

It used to be that nfsd accessed the ext2 inode generation number
directly, that's where the include came from, probably.

Olaf

> vfs.c does the same, but doesnt use anything from this header.
> 
> 
> Signed-off-by: Olaf Hering <olh@suse.de>
> 
> diff -purNx tags ../linux-2.6.11-rc4.orig/fs/nfsd/vfs.c ./fs/nfsd/vfs.c
> --- ../linux-2.6.11-rc4.orig/fs/nfsd/vfs.c	2005-02-13 04:06:05.000000000 +0100
> +++ ./fs/nfsd/vfs.c	2005-02-13 16:00:07.702972643 +0100
> @@ -24,7 +24,6 @@
>  #include <linux/file.h>
>  #include <linux/mount.h>
>  #include <linux/major.h>
> -#include <linux/ext2_fs.h>
>  #include <linux/proc_fs.h>
>  #include <linux/stat.h>
>  #include <linux/fcntl.h>
> 
> 
> -------------------------------------------------------
> SF email is sponsored by - The IT Product Guide
> Read honest & candid reviews on hundreds of IT Products from real users.
> Discover which products truly live up to the hype. Start reading now.
> http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
> _______________________________________________
> NFS maillist  -  NFS@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/nfs

-- 
Olaf Kirch   |  --- o --- Nous sommes du soleil we love when we play
okir@suse.de |    / | \   sol.dhoop.naytheet.ah kin.ir.samse.qurax


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] remove unneeded ext2 include from nfsd
  2005-02-14  9:31 ` Olaf Kirch
@ 2005-02-14  9:33   ` Olaf Hering
  0 siblings, 0 replies; 3+ messages in thread
From: Olaf Hering @ 2005-02-14  9:33 UTC (permalink / raw)
  To: Olaf Kirch; +Cc: Neil Brown, nfs

 On Mon, Feb 14, Olaf Kirch wrote:

> On Sun, Feb 13, 2005 at 04:52:57PM +0100, Olaf Hering wrote:
> > nfs3proc.c includes ext2 headers for some constants, strange.
> 
> It used to be that nfsd accessed the ext2 inode generation number
> directly, that's where the include came from, probably.

It looks for ext2/ext3 and msdos magic to tweak some settings.


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2005-02-14  9:33 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-02-13 15:52 [PATCH] remove unneeded ext2 include from nfsd Olaf Hering
2005-02-14  9:31 ` Olaf Kirch
2005-02-14  9:33   ` Olaf Hering

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.