All of lore.kernel.org
 help / color / mirror / Atom feed
* [KJ] [PATCH 2/18] drivers/atm/ remove pci_find_{device, subsys}
@ 2005-02-14  5:49 Amit Gud
  2005-02-14 18:49 ` Greg KH
  2005-02-15 13:46 ` chas williams - CONTRACTOR
  0 siblings, 2 replies; 3+ messages in thread
From: Amit Gud @ 2005-02-14  5:49 UTC (permalink / raw)
  To: kernel-janitors

[-- Attachment #1: Type: text/plain, Size: 709 bytes --]

Remove deprecated pci_find_device and pci_find_subsys


AG
--
May the source be with you


Signed-off-by: Amit Gud <gud@eth.net>

diff -uprN orig/drivers/atm/fore200e.c linux-2.6.11-rc3/drivers/atm/fore200e.c
--- orig/drivers/atm/fore200e.c	2005-02-11 15:19:41.000000000 +0530
+++ linux-2.6.11-rc3/drivers/atm/fore200e.c	2005-02-14 05:14:27.000000000 +0530
@@ -645,7 +645,7 @@ fore200e_pca_detect(const struct fore200
     int              count = index;
     
     do {
-	pci_dev = pci_find_device(PCI_VENDOR_ID_FORE, PCI_DEVICE_ID_FORE_PCA200E, pci_dev);
+	pci_dev = pci_get_device(PCI_VENDOR_ID_FORE, PCI_DEVICE_ID_FORE_PCA200E, pci_dev);
 	if (pci_dev == NULL)
 	    return NULL;
     } while (count--);


[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [KJ] [PATCH 2/18] drivers/atm/ remove pci_find_{device, subsys}
  2005-02-14  5:49 [KJ] [PATCH 2/18] drivers/atm/ remove pci_find_{device, subsys} Amit Gud
@ 2005-02-14 18:49 ` Greg KH
  2005-02-15 13:46 ` chas williams - CONTRACTOR
  1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2005-02-14 18:49 UTC (permalink / raw)
  To: kernel-janitors

[-- Attachment #1: Type: text/plain, Size: 869 bytes --]

On Mon, Feb 14, 2005 at 11:07:50AM +0530, Amit Gud wrote:
> Remove deprecated pci_find_device and pci_find_subsys
> 
> 
> AG
> --
> May the source be with you
> 
> 
> Signed-off-by: Amit Gud <gud@eth.net>
> 
> diff -uprN orig/drivers/atm/fore200e.c linux-2.6.11-rc3/drivers/atm/fore200e.c
> --- orig/drivers/atm/fore200e.c	2005-02-11 15:19:41.000000000 +0530
> +++ linux-2.6.11-rc3/drivers/atm/fore200e.c	2005-02-14 05:14:27.000000000 +0530
> @@ -645,7 +645,7 @@ fore200e_pca_detect(const struct fore200
>      int              count = index;
>      
>      do {
> -	pci_dev = pci_find_device(PCI_VENDOR_ID_FORE, PCI_DEVICE_ID_FORE_PCA200E, pci_dev);
> +	pci_dev = pci_get_device(PCI_VENDOR_ID_FORE, PCI_DEVICE_ID_FORE_PCA200E, pci_dev);
>  	if (pci_dev == NULL)
>  	    return NULL;
>      } while (count--);
> 

No, this is incorrect, please do not apply.

greg k-h


[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [KJ] [PATCH 2/18] drivers/atm/ remove pci_find_{device, subsys}
  2005-02-14  5:49 [KJ] [PATCH 2/18] drivers/atm/ remove pci_find_{device, subsys} Amit Gud
  2005-02-14 18:49 ` Greg KH
@ 2005-02-15 13:46 ` chas williams - CONTRACTOR
  1 sibling, 0 replies; 3+ messages in thread
From: chas williams - CONTRACTOR @ 2005-02-15 13:46 UTC (permalink / raw)
  To: kernel-janitors

[-- Attachment #1: Type: text/plain, Size: 358 bytes --]

In message <20050214184902.GV7815@kroah.com>,Greg KH writes:
>> -	pci_dev = pci_find_device(PCI_VENDOR_ID_FORE, PCI_DEVICE_ID_FORE_PCA200
>E, pci_dev);
>> +	pci_dev = pci_get_device(PCI_VENDOR_ID_FORE, PCI_DEVICE_ID_FORE_PCA200E
>
>No, this is incorrect, please do not apply.

i have a patch that fixes this the right way.  i will submit it later
this week.

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2005-02-15 13:46 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-02-14  5:49 [KJ] [PATCH 2/18] drivers/atm/ remove pci_find_{device, subsys} Amit Gud
2005-02-14 18:49 ` Greg KH
2005-02-15 13:46 ` chas williams - CONTRACTOR

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.