Re: scsi disk registration - double messages

[Patrick Mansfield <patmans@us.ibm.com>]

On Tue, Feb 15, 2005 at 02:33:35PM +0000, Matthew Wilcox wrote:
> On Tue, Feb 15, 2005 at 12:01:11PM +0200, Meelis Roos wrote:
> > The messages about registration of sda appear tiwice for some reason. This 
> > is only cosmetic but still a little strange:
> 
> Yes, that happens for everyone.

I posted before but no replies:

Al's log for the patch says "Work around devices with bogus media change
indication on the first open".

What bogus device? Why not put the change in the driver or black list
the device, rather than doing so for all block devices?

This worked fine for me, but I might break with the bogus media:

diff -uprN -X /home/patman/dontdiff linux-2.6.11-rc1/fs/partitions/check.c no-double-sd-linux-2.6.11-rc1/fs/partitions/check.c
--- linux-2.6.11-rc1/fs/partitions/check.c	Fri Dec 24 13:35:28 2004
+++ no-double-sd-linux-2.6.11-rc1/fs/partitions/check.c	Fri Jan 21 11:19:00 2005
@@ -375,8 +375,6 @@ int rescan_partitions(struct gendisk *di
 	bdev->bd_invalidated = 0;
 	for (p = 1; p < disk->minors; p++)
 		delete_partition(disk, p);
-	if (disk->fops->revalidate_disk)
-		disk->fops->revalidate_disk(disk);
 	if (!get_capacity(disk) || !(state = check_partition(disk, bdev)))
 		return 0;
 	for (p = 1; p < state->limit; p++) {

-- Patrick Mansfield