scsi disk registration - double messages

scsi disk registration - double messages

[Meelis Roos]

This is 2.6.11-rc4 on Sun SparcStation5 with onbpard ESP scsi, one 2.1G disk 
and one cdrom.

The messages about registration of sda appear tiwice for some reason. This is 
only cosmetic but still a little strange:

eth0: LANCE 08:00:20:90:36:e5
esp0: IRQ 36 SCSI ID 7 Clk 40MHz CCYC=25000 CCF=8 TOut 167 NCR53C9XF(espfast)
ESP: Total of 1 ESP hosts found, 1 actually in use.
scsi0 : Sparc ESP100A-FAST
   Vendor: IBM       Model: DCAS32160SUN2.1G  Rev: S65A
   Type:   Direct-Access                      ANSI SCSI revision: 02
   Vendor: TOSHIBA   Model: XM5701TASUN12XCD  Rev: 0997
   Type:   CD-ROM                             ANSI SCSI revision: 02
esp0: target 3 [period 100ns offset 15 10.00MHz FAST SCSI-II]
SCSI device sda: 4226725 512-byte hdwr sectors (2164 MB)
SCSI device sda: drive cache: write through
SCSI device sda: 4226725 512-byte hdwr sectors (2164 MB)
SCSI device sda: drive cache: write through
  sda: sda1 sda2 sda3 sda4
Attached scsi disk sda at scsi0, channel 0, id 3, lun 0

CONFIG_SCSI=y
# CONFIG_SCSI_PROC_FS is not set
CONFIG_BLK_DEV_SD=y
# CONFIG_CHR_DEV_ST is not set
# CONFIG_CHR_DEV_OSST is not set
CONFIG_BLK_DEV_SR=m
CONFIG_BLK_DEV_SR_VENDOR=y
CONFIG_CHR_DEV_SG=m
CONFIG_SCSI_MULTI_LUN=y
# CONFIG_SCSI_CONSTANTS is not set
# CONFIG_SCSI_LOGGING is not set
# CONFIG_SCSI_SPI_ATTRS is not set
# CONFIG_SCSI_FC_ATTRS is not set
# CONFIG_SCSI_ISCSI_ATTRS is not set
# CONFIG_SCSI_SATA is not set
# CONFIG_SCSI_PPA is not set
# CONFIG_SCSI_IMM is not set
# CONFIG_SCSI_QLOGICPTI is not set
# CONFIG_SCSI_DEBUG is not set
CONFIG_SCSI_SUNESP=y


-- 
Meelis Roos (mroos@linux.ee)

Re: scsi disk registration - double messages

[Matthew Wilcox]

On Tue, Feb 15, 2005 at 12:01:11PM +0200, Meelis Roos wrote:
> The messages about registration of sda appear tiwice for some reason. This 
> is only cosmetic but still a little strange:

Yes, that happens for everyone.

-- 
"Next the statesmen will invent cheap lies, putting the blame upon 
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince 
himself that the war is just, and will thank God for the better sleep 
he enjoys after this process of grotesque self-deception." -- Mark Twain

Re: scsi disk registration - double messages

[Patrick Mansfield]

On Tue, Feb 15, 2005 at 02:33:35PM +0000, Matthew Wilcox wrote:
> On Tue, Feb 15, 2005 at 12:01:11PM +0200, Meelis Roos wrote:
> > The messages about registration of sda appear tiwice for some reason. This 
> > is only cosmetic but still a little strange:
> 
> Yes, that happens for everyone.

I posted before but no replies:

Al's log for the patch says "Work around devices with bogus media change
indication on the first open".

What bogus device? Why not put the change in the driver or black list
the device, rather than doing so for all block devices?

This worked fine for me, but I might break with the bogus media:

diff -uprN -X /home/patman/dontdiff linux-2.6.11-rc1/fs/partitions/check.c no-double-sd-linux-2.6.11-rc1/fs/partitions/check.c
--- linux-2.6.11-rc1/fs/partitions/check.c	Fri Dec 24 13:35:28 2004
+++ no-double-sd-linux-2.6.11-rc1/fs/partitions/check.c	Fri Jan 21 11:19:00 2005
@@ -375,8 +375,6 @@ int rescan_partitions(struct gendisk *di
 	bdev->bd_invalidated = 0;
 	for (p = 1; p < disk->minors; p++)
 		delete_partition(disk, p);
-	if (disk->fops->revalidate_disk)
-		disk->fops->revalidate_disk(disk);
 	if (!get_capacity(disk) || !(state = check_partition(disk, bdev)))
 		return 0;
 	for (p = 1; p < state->limit; p++) {

-- Patrick Mansfield