[KJ] Re: drivers/scsi/aic7xxx/* - compile warning cleanup

[KJ] Re: drivers/scsi/aic7xxx/* - compile warning cleanup

[Domen Puncer]

[-- Attachment #1: Type: text/plain, Size: 989 bytes --]

On 15/02/05 00:02 +0200, Stephen Biggs wrote:
Content-Description: Mail message body
> Description: compile warning cleanup - handle error return from 
> scsi_add_host
> 
> Signed-off-by: Stephen Biggs <yrgrknmxpzlk@gawab.com>
> 
> diff -Nurdp -X dontdiff-osdl linux-2.6.11-rc3-mm2-original/drivers/scsi/aic7xxx/aic79xx_osm.c linux-2.6.11-rc3-mm2/drivers/scsi/aic7xxx/aic79xx_osm.c
> --- linux-2.6.11-rc3-mm2-original/drivers/scsi/aic7xxx/aic79xx_osm.c	2005-02-12 12:06:25.000000000 +0200
> +++ linux-2.6.11-rc3-mm2/drivers/scsi/aic7xxx/aic79xx_osm.c	2005-02-12 17:35:49.000000000 +0200
> @@ -2065,7 +2065,8 @@ ahd_linux_register_host(struct ahd_softc
>  	ahd_unlock(ahd, &s);
>  
>  #if LINUX_VERSION_CODE >= KERNEL_VERSION(2,5,0)
> -	scsi_add_host(host, &ahd->dev_softc->dev); /* XXX handle failure */
> +	if (scsi_add_host(host, &ahd->dev_softc->dev))
> +		return (EIO);

If it was that simple, I doubt they'd wrote the comment :-)
Everything has to be "undone" before return.


	Domen

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors