All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@suse.de>
To: Dave Olien <dmo@osdl.org>
Cc: Andrew Morton <akpm@osdl.org>, Linus Torvalds <torvalds@osdl.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	dm-devel@redhat.com
Subject: Re: [PATCH] Fix panic in 2.6 with bounced bio and dm
Date: Mon, 28 Feb 2005 18:40:13 +0100	[thread overview]
Message-ID: <20050228174012.GL8868@suse.de> (raw)
In-Reply-To: <20050228173542.GA16815@osdl.org>

On Mon, Feb 28 2005, Dave Olien wrote:
> 
> Just trivial, I think you're missing the final "0" argument
> in the __bio_for_each_segment().

Yep indeed, was just a hasty edit...

> 
> On Mon, Feb 28, 2005 at 04:51:28PM +0100, Jens Axboe wrote:
> > This should fix it.
> > 
> > Signed-off-by: Jens Axboe <axboe@suse.de>
> > 
> > 
> > ===== mm/highmem.c 1.55 vs edited =====
> > --- 1.55/mm/highmem.c	2005-01-08 06:44:13 +01:00
> > +++ edited/mm/highmem.c	2005-02-28 16:50:59 +01:00
> > @@ -425,7 +425,7 @@
> >  	 * at least one page was bounced, fill in possible non-highmem
> >  	 * pages
> >  	 */
> > -	bio_for_each_segment(from, *bio_orig, i) {
> > +	__bio_for_each_segment(from, *bio_orig, i) {
> >  		to = bio_iovec_idx(bio, i);
> >  		if (!to->bv_page) {
> >  			to->bv_page = from->bv_page;
> > 
> > -- 
> > Jens Axboe
> > 
> > -
> > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > Please read the FAQ at  http://www.tux.org/lkml/
> 

-- 
Jens Axboe

WARNING: multiple messages have this Message-ID (diff)
From: Jens Axboe <axboe@suse.de>
To: Dave Olien <dmo@osdl.org>
Cc: Mark Haverkamp <markh@osdl.org>,
	Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	dm-devel@redhat.com
Subject: Re: [PATCH] Fix panic in 2.6 with bounced bio and dm
Date: Mon, 28 Feb 2005 18:40:13 +0100	[thread overview]
Message-ID: <20050228174012.GL8868@suse.de> (raw)
In-Reply-To: <20050228173542.GA16815@osdl.org>

On Mon, Feb 28 2005, Dave Olien wrote:
> 
> Just trivial, I think you're missing the final "0" argument
> in the __bio_for_each_segment().

Yep indeed, was just a hasty edit...

> 
> On Mon, Feb 28, 2005 at 04:51:28PM +0100, Jens Axboe wrote:
> > This should fix it.
> > 
> > Signed-off-by: Jens Axboe <axboe@suse.de>
> > 
> > 
> > ===== mm/highmem.c 1.55 vs edited =====
> > --- 1.55/mm/highmem.c	2005-01-08 06:44:13 +01:00
> > +++ edited/mm/highmem.c	2005-02-28 16:50:59 +01:00
> > @@ -425,7 +425,7 @@
> >  	 * at least one page was bounced, fill in possible non-highmem
> >  	 * pages
> >  	 */
> > -	bio_for_each_segment(from, *bio_orig, i) {
> > +	__bio_for_each_segment(from, *bio_orig, i) {
> >  		to = bio_iovec_idx(bio, i);
> >  		if (!to->bv_page) {
> >  			to->bv_page = from->bv_page;
> > 
> > -- 
> > Jens Axboe
> > 
> > -
> > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > Please read the FAQ at  http://www.tux.org/lkml/
> 

-- 
Jens Axboe


  reply	other threads:[~2005-02-28 17:40 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-02-25 17:03 [PATCH] Fix panic in 2.6 with bounced bio and dm Mark Haverkamp
2005-02-25 17:13 ` Mark Haverkamp
2005-02-26  0:19 ` Andrew Morton
2005-02-26  0:19   ` Andrew Morton
2005-02-26  0:40   ` Linus Torvalds
2005-02-26 12:39     ` Jens Axboe
2005-02-26 12:39       ` Jens Axboe
2005-02-28 15:32       ` Mark Haverkamp
2005-02-28 15:32         ` Mark Haverkamp
2005-02-28 15:43         ` Mark Haverkamp
2005-02-28 15:43           ` Mark Haverkamp
2005-02-28 15:51         ` Jens Axboe
2005-02-28 15:51           ` Jens Axboe
2005-02-28 16:13           ` Mark Haverkamp
2005-02-28 16:13             ` Mark Haverkamp
2005-02-28 16:15             ` Mark Haverkamp
2005-02-28 16:15               ` Mark Haverkamp
2005-02-28 16:21             ` Jens Axboe
2005-02-28 16:21               ` Jens Axboe
2005-02-28 17:35           ` Dave Olien
2005-02-28 17:35             ` Dave Olien
2005-02-28 17:40             ` Jens Axboe [this message]
2005-02-28 17:40               ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050228174012.GL8868@suse.de \
    --to=axboe@suse.de \
    --cc=akpm@osdl.org \
    --cc=dm-devel@redhat.com \
    --cc=dmo@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.