v2.4 megaraid2 update Re: [PATCH] Prevent NMI oopser

v2.4 megaraid2 update Re: [PATCH] Prevent NMI oopser

[Marcelo Tosatti]

Hi, 

As the megaraid2 maintainers dont seem to care about v2.4 mainline at all, completly 
ignoring my requests to fix the NMI oopser bug for several months, I'm applying the RHEL3 
update + inline reordering, which should do it.

At this point I'm quite sure they wont answer this message either.  :( 

Thanks Vasily and Andrey.

On Mon, Feb 07, 2005 at 11:27:45PM +0300, Andrey J. Melnikoff (TEMHOTA) wrote:
> Hi Matt, Marcelo!
>  On Wed, Feb 02, 2005 at 02:19:14PM -0600, Matt Domsch wrote next:
> 
> > On Wed, Feb 02, 2005 at 10:32:28PM +0300, Vasily Averin wrote:
> > > >As a hack, one could #define inline /*nothing*/ in megaraid2.h to
> > > >avoid this, but it would be nice if the functions could all get
> > > >reordered such that inlining works properly, and the need for function
> > > >declarations in megaraid2.h would disappear completely.
> > > 
> > > 
> > > Could you fix it by additional patch? Or you going to prepare a new one?
> 
> Any chance to include this two patches before 2.4.30 release?
> 
> Vasily Averin patch:
> http://marc.theaimsgroup.com/?l=linux-kernel&m=110737085714273&w=2
> And my (incremental) patch:
> http://marc.theaimsgroup.com/?l=linux-kernel&m=110738438005846&w=2

RE: v2.4 megaraid2 update Re: [PATCH] Prevent NMI oopser

[Bagalkote, Sreenivas]

Hello Marcelo,

As per our offline conversation, I have verified the update that went into
2.4.30-pre2.
I confirm that all changes are correct. I have only one doubt: The driver
was using
sleep_on_timeout  for lack of msleep. Should it start using msleep now?

Vasily & Andrey, thank you for your efforts.

Thanks,
Sreenivas
LSI LOGIC Corporation


>-----Original Message-----
>From: Marcelo Tosatti [mailto:marcelo.tosatti@cyclades.com] 
>Sent: Wednesday, February 23, 2005 2:06 AM
>To: Andrey J. Melnikoff (TEMHOTA); Vasily Averin
>Cc: Matt Domsch; linux-kernel@vger.kernel.org; Mukker, Atul; 
>Bagalkote, Sreenivas
>Subject: v2.4 megaraid2 update Re: [PATCH] Prevent NMI oopser
>
>
>Hi, 
>
>As the megaraid2 maintainers dont seem to care about v2.4 
>mainline at all, completly 
>ignoring my requests to fix the NMI oopser bug for several 
>months, I'm applying the RHEL3 
>update + inline reordering, which should do it.
>
>At this point I'm quite sure they wont answer this message either.  :( 
>
>Thanks Vasily and Andrey.
>
>On Mon, Feb 07, 2005 at 11:27:45PM +0300, Andrey J. Melnikoff 
>(TEMHOTA) wrote:
>> Hi Matt, Marcelo!
>>  On Wed, Feb 02, 2005 at 02:19:14PM -0600, Matt Domsch wrote next:
>> 
>> > On Wed, Feb 02, 2005 at 10:32:28PM +0300, Vasily Averin wrote:
>> > > >As a hack, one could #define inline /*nothing*/ in 
>megaraid2.h to
>> > > >avoid this, but it would be nice if the functions could all get
>> > > >reordered such that inlining works properly, and the 
>need for function
>> > > >declarations in megaraid2.h would disappear completely.
>> > > 
>> > > 
>> > > Could you fix it by additional patch? Or you going to 
>prepare a new one?
>> 
>> Any chance to include this two patches before 2.4.30 release?
>> 
>> Vasily Averin patch:
>> http://marc.theaimsgroup.com/?l=linux-kernel&m=110737085714273&w=2
>> And my (incremental) patch:
>> http://marc.theaimsgroup.com/?l=linux-kernel&m=110738438005846&w=2
>

Re: v2.4 megaraid2 update Re: [PATCH] Prevent NMI oopser

[Marcelo Tosatti]

On Wed, Mar 02, 2005 at 11:26:06AM -0500, Bagalkote, Sreenivas wrote:
> Hello Marcelo,

Hi Sreenivas,

Damn, now I apologize for taking so long to answer... 

> As per our offline conversation, I have verified the update that went into
> 2.4.30-pre2.
> I confirm that all changes are correct. I have only one doubt: The driver
> was using
> sleep_on_timeout  for lack of msleep. Should it start using msleep now?

I dont see the need for msleep() given that sleep_on_timeout() schedules.

The problematic EH code which used udelay() was removed AFAICS.

> Vasily & Andrey, thank you for your efforts.

I appreciate your offline message that you're compromised to 
keep an eye on v2.4 megaraid2 from now on :)