From: Vojtech Pavlik <vojtech@suse.cz>
To: Daniel Barkalow <barkalow@iabervon.org>
Cc: Benoit Boissinot <bboissin@gmail.com>,
Dmitry Torokhov <dtor_core@ameritech.net>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>
Subject: Re: New ALPS code in -mm
Date: Mon, 7 Mar 2005 08:30:41 +0100 [thread overview]
Message-ID: <20050307073041.GA1956@ucw.cz> (raw)
In-Reply-To: <Pine.LNX.4.21.0503070204040.30848-100000@iabervon.org>
On Mon, Mar 07, 2005 at 02:14:17AM -0500, Daniel Barkalow wrote:
> On Fri, 4 Mar 2005, Vojtech Pavlik wrote:
>
> > /* Relative movement packet */
> > if (z == 127) {
> > - input_report_rel(dev2, REL_X, (x > 383 ? x : (x - 768)));
> > - input_report_rel(dev2, REL_Y, -(y > 255 ? y : (x - 512)));
> > + input_report_rel(dev2, REL_X, (x > 383 ? (x - 768) : x));
> > + input_report_rel(dev2, REL_Y, -(y > 255 ? (x - 512) : y));
>
> Not that I have any idea, but (y - 512) seems much more likely here.
>
> > + if ((priv->i->flags & ALPS_DUALPOINT) && z == 127) {
> > + input_report_key(dev2, BTN_LEFT, left);
> > + input_report_key(dev2, BTN_RIGHT, right);
> > + input_report_key(dev2, BTN_MIDDLE, middle);
> > + input_report_rel(dev2, REL_X, (x > 383 ? (x - 768) : x));
> > + input_report_rel(dev2, REL_Y, -(y > 255 ? (x - 512) : y));
>
> Also here.
Indeed. It took me a while to find it.
--
Vojtech Pavlik
SuSE Labs, SuSE CR
prev parent reply other threads:[~2005-03-07 7:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-24 23:29 ALPS tapping disabled. WHY? Ian E. Morgan
2005-02-25 3:08 ` Dmitry Torokhov
2005-02-27 7:50 ` Vojtech Pavlik
2005-02-28 22:23 ` Ian E. Morgan
2005-03-01 11:40 ` David Ford
2005-03-01 11:54 ` Vojtech Pavlik
2005-03-04 21:02 ` New ALPS code in -mm Benoit Boissinot
2005-03-04 21:13 ` Vojtech Pavlik
2005-03-07 7:14 ` Daniel Barkalow
2005-03-07 7:30 ` Vojtech Pavlik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050307073041.GA1956@ucw.cz \
--to=vojtech@suse.cz \
--cc=akpm@osdl.org \
--cc=barkalow@iabervon.org \
--cc=bboissin@gmail.com \
--cc=dtor_core@ameritech.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.