* Re: [KJ] [patch] fix typo in pm.h
2005-03-08 18:34 [KJ] [patch] fix typo in pm.h Coywolf Qi Hunt
@ 2005-03-08 18:48 ` Nishanth Aravamudan
2005-03-08 19:08 ` Coywolf Qi Hunt
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Nishanth Aravamudan @ 2005-03-08 18:48 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 1005 bytes --]
On Wed, Mar 09, 2005 at 02:34:00AM +0800, Coywolf Qi Hunt wrote:
> This patch fixes a typo in PMSG_ comment in pm.h.
>
> Signed-off-by: Coywolf Qi Hunt <coywolf@gmail.com>
>
> diff -Nrup 2.6.11/include/linux/pm.h 2.6.11-cy/include/linux/pm.h
> --- 2.6.11/include/linux/pm.h 2005-03-03 17:12:14.000000000 +0800
> +++ 2.6.11-cy/include/linux/pm.h 2005-03-09 02:27:07.000000000 +0800
> @@ -208,7 +208,7 @@ typedef u32 __bitwise pm_message_t;
> * pci D3.
> *
> * Unfortunately, current drivers only recognize numeric values 0
> (ON) and 3 (SUSPEND).
> - * We'll need to fix the drivers. So yes, putting 3 to all diferent
> defines is intentional,
> + * We'll need to fix the drivers. So yes, putting 3 to all different
> defines is intentional,
> * and will go away as soon as drivers are fixed. Also note that
> typedef is neccessary,
> * we'll probably want to switch to
> * typedef struct pm_message_t { int event; int flags; } pm_message_t
Your patch got wrapped.
Thanks,
Nish
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [KJ] [patch] fix typo in pm.h
2005-03-08 18:34 [KJ] [patch] fix typo in pm.h Coywolf Qi Hunt
2005-03-08 18:48 ` Nishanth Aravamudan
@ 2005-03-08 19:08 ` Coywolf Qi Hunt
2005-03-08 21:13 ` Nicolas Kaiser
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Coywolf Qi Hunt @ 2005-03-08 19:08 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 1029 bytes --]
On Tue, 8 Mar 2005 10:48:20 -0800, Nishanth Aravamudan <nacc@us.ibm.com> wrote:
> Your patch got wrapped.
>
This patch fixes a typo in PMSG_ comment in pm.h.
Signed-off-by: Coywolf Qi Hunt <coywolf@gmail.com>
diff -Nrup 2.6.11/include/linux/pm.h 2.6.11-cy/include/linux/pm.h
--- 2.6.11/include/linux/pm.h 2005-03-03 17:12:14.000000000 +0800
+++ 2.6.11-cy/include/linux/pm.h 2005-03-09 02:27:07.000000000 +0800
@@ -208,7 +208,7 @@ typedef u32 __bitwise pm_message_t;
* pci D3.
*
* Unfortunately, current drivers only recognize numeric values 0
(ON) and 3 (SUSPEND).
- * We'll need to fix the drivers. So yes, putting 3 to all diferent
defines is intentional,
+ * We'll need to fix the drivers. So yes, putting 3 to all different
defines is intentional,
* and will go away as soon as drivers are fixed. Also note that
typedef is neccessary,
* we'll probably want to switch to
* typedef struct pm_message_t { int event; int flags; } pm_message_t
--
Coywolf Qi Hunt
Homepage http://sosdg.org/~coywolf/
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [KJ] [patch] fix typo in pm.h
2005-03-08 18:34 [KJ] [patch] fix typo in pm.h Coywolf Qi Hunt
2005-03-08 18:48 ` Nishanth Aravamudan
2005-03-08 19:08 ` Coywolf Qi Hunt
@ 2005-03-08 21:13 ` Nicolas Kaiser
2005-03-08 21:23 ` Tobias Klauser
2005-03-08 22:12 ` Alexey Dobriyan
4 siblings, 0 replies; 6+ messages in thread
From: Nicolas Kaiser @ 2005-03-08 21:13 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 1247 bytes --]
* Coywolf Qi Hunt <coywolf@gmail.com>:
> This patch fixes a typo in PMSG_ comment in pm.h.
>
> Signed-off-by: Coywolf Qi Hunt <coywolf@gmail.com>
I just spotted two more. Patch together with your one.
--- linux-2.6.11/include/linux/pm.h.orig 2005-03-08 21:58:41.000000000 +0100
+++ linux-2.6.11/include/linux/pm.h 2005-03-08 22:01:08.000000000 +0100
@@ -153,7 +153,7 @@
#endif /* CONFIG_PM */
/* Functions above this comment are list-based old-style power
- * managment. Please avoid using them. */
+ * management. Please avoid using them. */
/*
* Callbacks for platform drivers to implement.
@@ -208,8 +208,8 @@
* pci D3.
*
* Unfortunately, current drivers only recognize numeric values 0 (ON) and 3 (SUSPEND).
- * We'll need to fix the drivers. So yes, putting 3 to all diferent defines is intentional,
- * and will go away as soon as drivers are fixed. Also note that typedef is neccessary,
+ * We'll need to fix the drivers. So yes, putting 3 to all different defines is intentional,
+ * and will go away as soon as drivers are fixed. Also note that typedef is necessary,
* we'll probably want to switch to
* typedef struct pm_message_t { int event; int flags; } pm_message_t
* or something similar soon.
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [KJ] [patch] fix typo in pm.h
2005-03-08 18:34 [KJ] [patch] fix typo in pm.h Coywolf Qi Hunt
` (2 preceding siblings ...)
2005-03-08 21:13 ` Nicolas Kaiser
@ 2005-03-08 21:23 ` Tobias Klauser
2005-03-08 22:12 ` Alexey Dobriyan
4 siblings, 0 replies; 6+ messages in thread
From: Tobias Klauser @ 2005-03-08 21:23 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 323 bytes --]
On Wed, Mar 09, 2005 at 03:08:13AM +0800, Coywolf Qi Hunt wrote:
> On Tue, 8 Mar 2005 10:48:20 -0800, Nishanth Aravamudan <nacc@us.ibm.com> wrote:
> > Your patch got wrapped.
> >
>
> This patch fixes a typo in PMSG_ comment in pm.h.
Your patch is still wrapped. You may want to use mutt as a mailer. ;-)
Cheers, Tobias
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [KJ] [patch] fix typo in pm.h
2005-03-08 18:34 [KJ] [patch] fix typo in pm.h Coywolf Qi Hunt
` (3 preceding siblings ...)
2005-03-08 21:23 ` Tobias Klauser
@ 2005-03-08 22:12 ` Alexey Dobriyan
4 siblings, 0 replies; 6+ messages in thread
From: Alexey Dobriyan @ 2005-03-08 22:12 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 732 bytes --]
On Tuesday 08 March 2005 23:13, Nicolas Kaiser wrote:
> - * managment. Please avoid using them. */
> + * management. Please avoid using them. */
> - * We'll need to fix the drivers. So yes, putting 3 to all diferent defines is intentional,
> - * and will go away as soon as drivers are fixed. Also note that typedef is neccessary,
> + * We'll need to fix the drivers. So yes, putting 3 to all different defines is intentional,
> + * and will go away as soon as drivers are fixed. Also note that typedef is necessary,
Always grep the entire tree if typo is found. You know, identical keyboards,
people copy, ... ;-)
linux-2.6.11-bk4]$ grep managment -r . | wc -l
21
linux-2.6.11-bk4]$ grep neccessary -r . | wc -l
18
Alexey
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 6+ messages in thread