From: Dave Jones <davej@redhat.com>
To: Christoph Lameter <clameter@sgi.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] mm counter operations through macros
Date: Fri, 11 Mar 2005 13:25:00 -0500 [thread overview]
Message-ID: <20050311182500.GA4185@redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.58.0503110422150.19280@schroedinger.engr.sgi.com>
On Fri, Mar 11, 2005 at 04:23:21AM -0800, Christoph Lameter wrote:
> This patch extracts all the operations on counters protected by the
> page table lock (currently rss and anon_rss) into definitions in
> include/linux/sched.h. All rss operations are performed through
> the following three macros:
>
> get_mm_counter(mm, member) -> Obtain the value of a counter
> set_mm_counter(mm, member, value) -> Set the value of a counter
> update_mm_counter(mm, member, value) -> Add a value to a counter
Splitting this last one into inc_mm_counter() and dec_mm_counter()
means you can kill off the last argument, and get some of the
readability back. As it stands, I think this patch adds a bunch
of obfuscation for no clear benefit.
Dave
WARNING: multiple messages have this Message-ID (diff)
From: Dave Jones <davej@redhat.com>
To: Christoph Lameter <clameter@sgi.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] mm counter operations through macros
Date: Fri, 11 Mar 2005 13:25:00 -0500 [thread overview]
Message-ID: <20050311182500.GA4185@redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.58.0503110422150.19280@schroedinger.engr.sgi.com>
On Fri, Mar 11, 2005 at 04:23:21AM -0800, Christoph Lameter wrote:
> This patch extracts all the operations on counters protected by the
> page table lock (currently rss and anon_rss) into definitions in
> include/linux/sched.h. All rss operations are performed through
> the following three macros:
>
> get_mm_counter(mm, member) -> Obtain the value of a counter
> set_mm_counter(mm, member, value) -> Set the value of a counter
> update_mm_counter(mm, member, value) -> Add a value to a counter
Splitting this last one into inc_mm_counter() and dec_mm_counter()
means you can kill off the last argument, and get some of the
readability back. As it stands, I think this patch adds a bunch
of obfuscation for no clear benefit.
Dave
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
next prev parent reply other threads:[~2005-03-11 18:49 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-11 12:23 [PATCH] mm counter operations through macros Christoph Lameter
2005-03-11 12:23 ` Christoph Lameter
2005-03-11 18:25 ` Dave Jones [this message]
2005-03-11 18:25 ` Dave Jones
2005-03-11 19:04 ` Christoph Lameter
2005-03-11 19:04 ` Christoph Lameter
2005-03-11 22:52 ` Andrew Morton
2005-03-11 22:52 ` Andrew Morton
2005-03-12 0:35 ` Christoph Lameter
2005-03-12 0:35 ` Christoph Lameter
2005-03-12 13:57 ` Nikita Danilov
2005-03-12 13:57 ` Nikita Danilov
2005-03-15 5:04 ` Christoph Lameter
2005-03-15 5:04 ` Christoph Lameter
2005-03-15 5:45 ` Andrew Morton
2005-03-15 5:45 ` Andrew Morton
2005-03-15 5:50 ` Christoph Lameter
2005-03-15 5:50 ` Christoph Lameter
2005-03-15 5:59 ` Andrew Morton
2005-03-15 5:59 ` Andrew Morton
2005-03-15 6:10 ` Christoph Lameter
2005-03-15 6:10 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050311182500.GA4185@redhat.com \
--to=davej@redhat.com \
--cc=clameter@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.