From: Gerd Knorr <kraxel@bytesex.org>
To: Ian Pratt <m+Ian.Pratt@cl.cam.ac.uk>
Cc: Keir Fraser <Keir.Fraser@cl.cam.ac.uk>,
xen-devel@lists.sourceforge.net, ian.pratt@cl.cam.ac.uk
Subject: Re: [patch/unstable] page table cleanups
Date: Mon, 14 Mar 2005 16:14:48 +0100 [thread overview]
Message-ID: <20050314151448.GA13710@bytesex> (raw)
In-Reply-To: <A95E2296287EAD4EB592B5DEEFCE0E9D1E3649@liverpoolst.ad.cl.cam.ac.uk>
Hi,
> I guess I'd prefer to have it be a scalar type because all the accessor
> macros actually do a pretty good job of obfusticating the code -- you
> see mk_( _val( X ) [logical op]) all over the place.
Yes, that is not so nice ...
> One way to fix this would be to have a better accessor macro for
> performing logical ops on the flags field of a pgentry.
I've already considered changing the accessor macros for performance
reasons. With separate macros to read/write pfn and the flags it is
also possible to get away with 32 bit instead of 64 bit operations for
page flag checks and updates.
I think I'll go this route then ;)
Gerd
--
#define printk(args...) fprintf(stderr, ## args)
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
next prev parent reply other threads:[~2005-03-14 15:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-14 14:00 [patch/unstable] page table cleanups Ian Pratt
2005-03-14 15:14 ` Gerd Knorr [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-03-14 12:07 Gerd Knorr
2005-03-14 12:49 ` Keir Fraser
2005-03-14 13:36 ` Gerd Knorr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050314151448.GA13710@bytesex \
--to=kraxel@bytesex.org \
--cc=Keir.Fraser@cl.cam.ac.uk \
--cc=ian.pratt@cl.cam.ac.uk \
--cc=m+Ian.Pratt@cl.cam.ac.uk \
--cc=xen-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.