All of lore.kernel.org
 help / color / mirror / Atom feed
From: greg@kroah.com (Greg KH)
To: Corey Minyard <minyard@acm.org>
Cc: lkml <linux-kernel@vger.kernel.org>,
	Sensors <sensors@stimpy.netroedge.com>
Subject: [PATCH] Add a non-blocking interface to the I2C code, part 1
Date: Thu, 19 May 2005 06:25:43 +0000	[thread overview]
Message-ID: <20050317070940.GA15508@kroah.com> (raw)
In-Reply-To: <42261AFB.40001@acm.org>

On Wed, Mar 02, 2005 at 01:58:51PM -0600, Corey Minyard wrote:
> This patch reorganizes the I2C SMBus formatting code to make it more
> suitable for the upcoming non-blocking changes.

You are changing too much stuff here to claim it's just a
reorganization:
	- variable name changes for no reason
	- coding style changes (improper ones at that)
	- logic changes.

What exactly are you doing with this patch, and why?

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <greg@kroah.com>
To: Corey Minyard <minyard@acm.org>
Cc: lkml <linux-kernel@vger.kernel.org>,
	Sensors <sensors@stimpy.netroedge.com>
Subject: Re: [PATCH] Add a non-blocking interface to the I2C code, part 1
Date: Wed, 16 Mar 2005 23:09:40 -0800	[thread overview]
Message-ID: <20050317070940.GA15508@kroah.com> (raw)
In-Reply-To: <42261AFB.40001@acm.org>

On Wed, Mar 02, 2005 at 01:58:51PM -0600, Corey Minyard wrote:
> This patch reorganizes the I2C SMBus formatting code to make it more
> suitable for the upcoming non-blocking changes.

You are changing too much stuff here to claim it's just a
reorganization:
	- variable name changes for no reason
	- coding style changes (improper ones at that)
	- logic changes.

What exactly are you doing with this patch, and why?

thanks,

greg k-h

  reply	other threads:[~2005-05-19  6:25 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-02 19:58 [PATCH] Add a non-blocking interface to the I2C code, part 1 Corey Minyard
2005-05-19  6:25 ` Corey Minyard
2005-03-17  7:09 ` Greg KH [this message]
2005-05-19  6:25   ` Greg KH
2005-03-18 16:13   ` Corey Minyard
2005-05-19  6:25     ` Corey Minyard
  -- strict thread matches above, loose matches on Subject: below --
2005-03-02 20:00 [PATCH] Add a non-blocking interface to the I2C code, part 2 Corey Minyard
2005-05-19  6:25 ` Corey Minyard
2005-03-02 20:01 [PATCH] Add a non-blocking interface to the I2C code, part3 Corey Minyard
2005-05-19  6:25 ` Corey Minyard
2005-03-02 20:02 [PATCH] Add a non-blocking interface to the I2C code, part 4 Corey Minyard
2005-05-19  6:25 ` Corey Minyard
2005-03-02 20:02 [PATCH] Add a non-blocking interface to the I2C code, part 5 Corey Minyard
2005-05-19  6:25 ` Corey Minyard
2005-03-02 20:04 [PATCH] Add a non-blocking interface to the I2C code, part 6 Corey Minyard
2005-05-19  6:25 ` Corey Minyard
2005-03-02 20:04 [PATCH] Add a non-blocking interface to the I2C code, part 7 Corey Minyard
2005-05-19  6:25 ` Corey Minyard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050317070940.GA15508@kroah.com \
    --to=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=minyard@acm.org \
    --cc=sensors@stimpy.netroedge.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.