All of lore.kernel.org
 help / color / mirror / Atom feed
From: adaplas@hotpop.com (Antonino A. Daplas)
To: lm-sensors@vger.kernel.org
Subject: Who should I write to about this OOPS in 2,6,11-mm3?
Date: Thu, 19 May 2005 06:25:43 +0000	[thread overview]
Message-ID: <200503180702.42247.adaplas@hotpop.com> (raw)
In-Reply-To: <20050315050746.GB13009@kroah.com>

On Friday 18 March 2005 06:03, Jean Delvare wrote:
> Hi Tony,
>
> > Before I go on debugging, a few questions, as my knowledge of the i2c
> > framework is quite limited:
> >
> > This particular bug seems to be triggered in i2c_dev_init when calling
> > i2c_add_driver.
>
> Were you able to reproduce this one as well? I couldn't.

Can't either.

>
> > 1. nvidiafb gets loaded before i2c_dev_init(), and when setting up
> > i2c, calls i2c_bit_add_bus. Is this safe to do?
>
> Looks OK to me. nvidiafb, like other framebuffer drivers, declares i2c
> busses. i2c-dev declares an i2c driver. Both are rather independent, and
> supposedly don't interract before an i2c client is created (that would
> happen in i2cdev_open()).
>
> i2c-dev isn't really part of i2c-core, it's more like a priviledged i2c
> pseudo-chip driver.

Ok, just making sure.

>
> > 2.  In i2c_add_driver, there is a call to list_add_tail.  Is this
> > acceptable without doing a LIST_HEAD_INIT first?  Or is the list_head
> > initialized somewhere?
>
> The list is declared with:
> static LIST_HEAD(drivers);

Ok, I mistakenly interchanged the parameters of list_*. I thought the second
parameter is the entry to be added to the list_head, the first parameter.

> at the top of i2c-core.c.
> Looks OK to me but I am no list expert.

I was talking about driver->list, because of my mistaken belief as mentioned
above, where it is initialized.  Anyway, after checking the i2c code, I
don't see where driver->list used anywhere, so I don't think it will hit a
bug.

Tony


  parent reply	other threads:[~2005-05-19  6:25 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-19  6:25 Who should I write to about this OOPS in 2,6,11-mm3? Greg KH
2005-05-19  6:25 ` Jean Delvare
2005-05-19  6:25 ` Jean Delvare
2005-05-19  6:25 ` Miles Lane
2005-05-19  6:25 ` Antonino A. Daplas
2005-05-19  6:25 ` Jean Delvare
2005-05-19  6:25 ` Miles Lane
2005-05-19  6:25 ` Jean Delvare
2005-05-19  6:25 ` Miles Lane
2005-05-19  6:25 ` Antonino A. Daplas
2005-05-19  6:25 ` Antonino A. Daplas
2005-05-19  6:25 ` Antonino A. Daplas [this message]
     [not found]   ` <20050317154226.24c1f8f8.akpm@osdl.org>
     [not found]     ` <200503180754.21258.adaplas@hotpop.com>
2005-03-22  2:40       ` Andrew Morton
2005-03-22  2:59         ` Miles Lane
2005-05-19  6:25           ` Miles Lane
2005-05-19  6:25 ` Antonino A. Daplas
2005-05-19  6:25 ` Jean Delvare
2005-05-19  6:25 ` Jean Delvare
2005-05-19  6:25 ` Antonino A. Daplas
2005-05-19  6:25 ` Andrew Morton
2005-05-19  6:25 ` Jean Delvare
2005-05-19  6:25 ` Andrew Morton
2005-05-19  6:25 ` Miles Lane
2005-05-19  6:25 ` Andrew Morton
2005-05-19  6:25 ` Miles Lane
2005-05-19  6:25 ` Miles Lane
2005-05-19  6:25 ` Miles Lane
2005-05-19  6:25 ` Jean Delvare
2005-05-19  6:25 ` Greg KH
2005-05-19  6:25 ` Andrew Morton
2005-05-19  6:25 ` Miles Lane
2005-05-19  6:25 ` Andrew Morton
2005-05-19  6:25 ` Jean Delvare
2005-05-19  6:25 ` Miles Lane
2005-05-19  6:25 ` Miles Lane
2005-05-19  6:25 ` Miles Lane
2005-05-19  6:25 ` Jean Delvare
2005-05-19  6:25 ` Miles Lane
2005-05-19  6:25 ` Andrew Morton
2005-05-19  6:25 ` Miles Lane
2005-05-19  6:25 ` Miles Lane
2005-05-19  6:25 ` Miles Lane
2005-05-26  9:05 ` [lm-sensors] Re: Who should I write to about this OOPS in 2, 6, Andrew Morton
2005-05-26  9:05 ` Greg KH
2005-05-26  9:05 ` Miles Lane
2005-05-26  9:05 ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200503180702.42247.adaplas@hotpop.com \
    --to=adaplas@hotpop.com \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.