All of lore.kernel.org
 help / color / mirror / Atom feed
From: Domen Puncer <domen@coderock.org>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] [PATCH] printk : drivers/media/dvb/ttpci/av7110_ipack.c
Date: Fri, 18 Mar 2005 14:04:51 +0000	[thread overview]
Message-ID: <20050318140451.GE4006@nd47.coderock.org> (raw)
In-Reply-To: <20050318115049.GG17789@rhum.iomeda.fr>

[-- Attachment #1: Type: text/plain, Size: 583 bytes --]

On 18/03/05 12:50 +0100, Christophe Lucas wrote:
> 
> Hi,
> 
> Description:
> printk() calls should include appropriate KERN_* constant.

Doesn't apply to 2.6.11-rc1.

> 
> Have a nice day,

Can you drop this in patches otherwise someone else has to drop it (or
it ends in bitkeeper).
I already make script to strip "hi, hello, description, consider
applying...", i'm not adding every possible regard in there :-)


> -		printk ("Couldn't allocate memory for ipack\n");
> +		printk (KERN_WARNING "Couldn't allocate memory for ipack\n");

		      ^
You could get rid of this space.



[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

      reply	other threads:[~2005-03-18 14:04 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-18 11:50 [KJ] [PATCH] printk : drivers/media/dvb/ttpci/av7110_ipack.c Christophe Lucas
2005-03-18 14:04 ` Domen Puncer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050318140451.GE4006@nd47.coderock.org \
    --to=domen@coderock.org \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.