[KJ] [PATCH] printk : drivers/media/dvb/ttpci/av7110_ipack.c

[KJ] [PATCH] printk : drivers/media/dvb/ttpci/av7110_ipack.c

[Christophe Lucas]

[-- Attachment #1: Type: text/plain, Size: 153 bytes --]


Hi,

Description:
printk() calls should include appropriate KERN_* constant.

Have a nice day,

Signed-off-by: Christophe Lucas <clucas@rotomalug.org>


[-- Attachment #2: patch-linux-2.6.11_drivers_media_dvb_ttpci_av7110_ipack.c.diff --]
[-- Type: text/plain, Size: 649 bytes --]

diff -urpN -X dontdiff linux-2.6.11-vanilla/drivers/media/dvb/ttpci/av7110_ipack.c linux-2.6.11/drivers/media/dvb/ttpci/av7110_ipack.c
--- linux-2.6.11-vanilla/drivers/media/dvb/ttpci/av7110_ipack.c	2005-03-02 08:38:07.000000000 +0100
+++ linux-2.6.11/drivers/media/dvb/ttpci/av7110_ipack.c	2005-03-16 11:57:03.000000000 +0100
@@ -24,7 +24,7 @@ int av7110_ipack_init(struct ipack *p, i
 		       void (*func)(u8 *buf, int size, void *priv))
 {
 	if ( !(p->buf = vmalloc(size*sizeof(u8))) ){
-		printk ("Couldn't allocate memory for ipack\n");
+		printk (KERN_WARNING "Couldn't allocate memory for ipack\n");
 		return -ENOMEM;
 	}
 	p->size = size;

[-- Attachment #3: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [KJ] [PATCH] printk : drivers/media/dvb/ttpci/av7110_ipack.c

[Domen Puncer]

[-- Attachment #1: Type: text/plain, Size: 583 bytes --]

On 18/03/05 12:50 +0100, Christophe Lucas wrote:
> 
> Hi,
> 
> Description:
> printk() calls should include appropriate KERN_* constant.

Doesn't apply to 2.6.11-rc1.

> 
> Have a nice day,

Can you drop this in patches otherwise someone else has to drop it (or
it ends in bitkeeper).
I already make script to strip "hi, hello, description, consider
applying...", i'm not adding every possible regard in there :-)


> -		printk ("Couldn't allocate memory for ipack\n");
> +		printk (KERN_WARNING "Couldn't allocate memory for ipack\n");

		      ^
You could get rid of this space.



[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors