* [KJ] [PATCH 19/19] drivers/scsi/sata_vsc: Use the DMA_{64,
@ 2005-02-20 17:13 ` Tobias Klauser
0 siblings, 0 replies; 6+ messages in thread
From: Tobias Klauser @ 2005-02-20 17:13 UTC (permalink / raw)
To: kernel-janitors; +Cc: linux-scsi
[-- Attachment #1: Type: text/plain, Size: 857 bytes --]
Hello,
Description: Use the DMA_{64,32}BIT_MASK constants from dma-mapping.h
when calling pci_set_dma_mask() or pci_set_consistent_dma_mask()
See http://marc.theaimsgroup.com/?t=108001993000001&r=1&w=2 for details
Signed-off-by: Tobias Klauser <tklauser@nuerscht.ch>
--- linux-2.6.11-rc4.orig/drivers/scsi/sata_vsc.c 2005-02-13 17:13:07.000000000 +0100
+++ linux-2.6.11-rc4/drivers/scsi/sata_vsc.c 2005-02-16 21:25:01.000000000 +0100
@@ -280,10 +280,10 @@ static int __devinit vsc_sata_init_one (
/*
* Use 32 bit DMA mask, because 64 bit address support is poor.
*/
- rc = pci_set_dma_mask(pdev, 0xFFFFFFFFULL);
+ rc = pci_set_dma_mask(pdev, DMA_32BIT_MASK);
if (rc)
goto err_out_regions;
- rc = pci_set_consistent_dma_mask(pdev, 0xFFFFFFFFULL);
+ rc = pci_set_consistent_dma_mask(pdev, DMA_32BIT_MASK);
if (rc)
goto err_out_regions;
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 19/19] drivers/scsi/sata_vsc: Use the DMA_{64,32}BIT_MASK constants
@ 2005-02-20 17:13 ` Tobias Klauser
0 siblings, 0 replies; 6+ messages in thread
From: Tobias Klauser @ 2005-02-20 17:13 UTC (permalink / raw)
To: kernel-janitors; +Cc: linux-scsi
Hello,
Description: Use the DMA_{64,32}BIT_MASK constants from dma-mapping.h
when calling pci_set_dma_mask() or pci_set_consistent_dma_mask()
See http://marc.theaimsgroup.com/?t=108001993000001&r=1&w=2 for details
Signed-off-by: Tobias Klauser <tklauser@nuerscht.ch>
--- linux-2.6.11-rc4.orig/drivers/scsi/sata_vsc.c 2005-02-13 17:13:07.000000000 +0100
+++ linux-2.6.11-rc4/drivers/scsi/sata_vsc.c 2005-02-16 21:25:01.000000000 +0100
@@ -280,10 +280,10 @@ static int __devinit vsc_sata_init_one (
/*
* Use 32 bit DMA mask, because 64 bit address support is poor.
*/
- rc = pci_set_dma_mask(pdev, 0xFFFFFFFFULL);
+ rc = pci_set_dma_mask(pdev, DMA_32BIT_MASK);
if (rc)
goto err_out_regions;
- rc = pci_set_consistent_dma_mask(pdev, 0xFFFFFFFFULL);
+ rc = pci_set_consistent_dma_mask(pdev, DMA_32BIT_MASK);
if (rc)
goto err_out_regions;
^ permalink raw reply [flat|nested] 6+ messages in thread
* [KJ] Re: [PATCH 19/19] drivers/scsi/sata_vsc: Use the DMA_{64,
2005-02-20 17:13 ` [PATCH 19/19] drivers/scsi/sata_vsc: Use the DMA_{64,32}BIT_MASK constants Tobias Klauser
@ 2005-02-24 5:34 ` Jeff Garzik
-1 siblings, 0 replies; 6+ messages in thread
From: Jeff Garzik @ 2005-02-24 5:34 UTC (permalink / raw)
To: Tobias Klauser; +Cc: kernel-janitors, linux-scsi
[-- Attachment #1: Type: text/plain, Size: 164 bytes --]
Applied patch #4 and #19 to libata.
Please do not include "Hello," or "Description:" in your patch
description, as I must hand-edit these out manually.
Jeff
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 19/19] drivers/scsi/sata_vsc: Use the DMA_{64,32}BIT_MASK constants
@ 2005-02-24 5:34 ` Jeff Garzik
0 siblings, 0 replies; 6+ messages in thread
From: Jeff Garzik @ 2005-02-24 5:34 UTC (permalink / raw)
To: Tobias Klauser; +Cc: kernel-janitors, linux-scsi
Applied patch #4 and #19 to libata.
Please do not include "Hello," or "Description:" in your patch
description, as I must hand-edit these out manually.
Jeff
^ permalink raw reply [flat|nested] 6+ messages in thread
* [KJ] [UPDATE PATCH 19/19] drivers/scsi/sata_vsc: Use the
2005-02-20 17:13 ` [PATCH 19/19] drivers/scsi/sata_vsc: Use the DMA_{64,32}BIT_MASK constants Tobias Klauser
@ 2005-03-20 13:23 ` Tobias Klauser
-1 siblings, 0 replies; 6+ messages in thread
From: Tobias Klauser @ 2005-03-20 13:23 UTC (permalink / raw)
To: kernel-janitors; +Cc: jgarzik, linux-ide
[-- Attachment #1: Type: text/plain, Size: 1227 bytes --]
The previous patch did not compile cleanly on all architectures so
here's a fixed one.
Use the DMA_{64,32}BIT_MASK constants from dma-mapping.h when calling
pci_set_dma_mask() or pci_set_consistent_dma_mask()
This patch includes dma-mapping.h explicitly because it caused errors
on some architectures otherwise.
See http://marc.theaimsgroup.com/?t=108001993000001&r=1&w=2 for details
Signed-off-by: Tobias Klauser <tklauser@nuerscht.ch>
--- linux-2.6.11.orig/drivers/scsi/sata_vsc.c 2005-03-02 12:50:38.000000000 +0100
+++ linux-2.6.11/drivers/scsi/sata_vsc.c 2005-03-20 13:27:54.000000000 +0100
@@ -21,6 +21,7 @@
#include <linux/blkdev.h>
#include <linux/delay.h>
#include <linux/interrupt.h>
+#include <linux/dma-mapping.h>
#include "scsi.h"
#include <scsi/scsi_host.h>
#include <linux/libata.h>
@@ -285,10 +286,10 @@ static int __devinit vsc_sata_init_one (
/*
* Use 32 bit DMA mask, because 64 bit address support is poor.
*/
- rc = pci_set_dma_mask(pdev, 0xFFFFFFFFULL);
+ rc = pci_set_dma_mask(pdev, DMA_32BIT_MASK);
if (rc)
goto err_out_regions;
- rc = pci_set_consistent_dma_mask(pdev, 0xFFFFFFFFULL);
+ rc = pci_set_consistent_dma_mask(pdev, DMA_32BIT_MASK);
if (rc)
goto err_out_regions;
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 6+ messages in thread
* [UPDATE PATCH 19/19] drivers/scsi/sata_vsc: Use the DMA_32BIT_MASK constant
@ 2005-03-20 13:23 ` Tobias Klauser
0 siblings, 0 replies; 6+ messages in thread
From: Tobias Klauser @ 2005-03-20 13:23 UTC (permalink / raw)
To: kernel-janitors; +Cc: jgarzik, linux-ide
The previous patch did not compile cleanly on all architectures so
here's a fixed one.
Use the DMA_{64,32}BIT_MASK constants from dma-mapping.h when calling
pci_set_dma_mask() or pci_set_consistent_dma_mask()
This patch includes dma-mapping.h explicitly because it caused errors
on some architectures otherwise.
See http://marc.theaimsgroup.com/?t=108001993000001&r=1&w=2 for details
Signed-off-by: Tobias Klauser <tklauser@nuerscht.ch>
--- linux-2.6.11.orig/drivers/scsi/sata_vsc.c 2005-03-02 12:50:38.000000000 +0100
+++ linux-2.6.11/drivers/scsi/sata_vsc.c 2005-03-20 13:27:54.000000000 +0100
@@ -21,6 +21,7 @@
#include <linux/blkdev.h>
#include <linux/delay.h>
#include <linux/interrupt.h>
+#include <linux/dma-mapping.h>
#include "scsi.h"
#include <scsi/scsi_host.h>
#include <linux/libata.h>
@@ -285,10 +286,10 @@ static int __devinit vsc_sata_init_one (
/*
* Use 32 bit DMA mask, because 64 bit address support is poor.
*/
- rc = pci_set_dma_mask(pdev, 0xFFFFFFFFULL);
+ rc = pci_set_dma_mask(pdev, DMA_32BIT_MASK);
if (rc)
goto err_out_regions;
- rc = pci_set_consistent_dma_mask(pdev, 0xFFFFFFFFULL);
+ rc = pci_set_consistent_dma_mask(pdev, DMA_32BIT_MASK);
if (rc)
goto err_out_regions;
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2005-03-20 13:23 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-02-20 17:13 [KJ] [PATCH 19/19] drivers/scsi/sata_vsc: Use the DMA_{64, Tobias Klauser
2005-02-20 17:13 ` [PATCH 19/19] drivers/scsi/sata_vsc: Use the DMA_{64,32}BIT_MASK constants Tobias Klauser
2005-02-24 5:34 ` [KJ] Re: [PATCH 19/19] drivers/scsi/sata_vsc: Use the DMA_{64, Jeff Garzik
2005-02-24 5:34 ` [PATCH 19/19] drivers/scsi/sata_vsc: Use the DMA_{64,32}BIT_MASK constants Jeff Garzik
2005-03-20 13:23 ` [KJ] [UPDATE PATCH 19/19] drivers/scsi/sata_vsc: Use the Tobias Klauser
2005-03-20 13:23 ` [UPDATE PATCH 19/19] drivers/scsi/sata_vsc: Use the DMA_32BIT_MASK constant Tobias Klauser
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.