From: "Yoshinori K. Okuji" <okuji@enbug.org>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: Grub2 on Mac OS X
Date: Tue, 22 Mar 2005 21:20:43 +0100 [thread overview]
Message-ID: <200503222120.43235.okuji@enbug.org> (raw)
In-Reply-To: <1111431300.423f1884b4a97@imp4-q.free.fr>
On Monday 21 March 2005 07:55 pm, Antoine Terrienne wrote:
> Here is a patch with the modifications I made. Please tell me if some of
> them are wrong. I hope I would help.
Could you make a patch with -u? The standard diff format is too difficult for
me.
I describe what I think are not appropriate in your patch:
- memalign should not be just a macro. memalign is not the same as malloc.
- The macro _MACOSX_ should not be defined. OS-specific code should be enabled
in a more generic way. Take a look at the autoconf manual and the autobook
<http://sources.redhat.com/autobook/>.
- Rather than replacing argp with getopt, please include the standalone
version of argp <http://gd.tuwien.ac.at/utils/shells/lsh/>.
- ChangeLog, please.
Okuji
next prev parent reply other threads:[~2005-03-22 20:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-21 18:55 Grub2 on Mac OS X Antoine Terrienne
2005-03-22 20:20 ` Yoshinori K. Okuji [this message]
2005-03-23 20:42 ` Brian Sammon
2005-03-23 21:09 ` Yoshinori K. Okuji
2005-03-26 13:37 ` Marco Gerards
-- strict thread matches above, loose matches on Subject: below --
2005-03-23 13:20 antoine terrienne
2005-03-23 20:45 ` Yoshinori K. Okuji
2005-03-23 22:28 ` Antoine Terrienne
2005-03-26 0:22 ` Yoshinori K. Okuji
2005-03-26 12:09 ` Antoine Terrienne
2005-03-26 13:52 ` Marco Gerards
2005-03-26 14:55 ` Antoine Terrienne
2005-03-26 15:20 ` Marco Gerards
2005-03-26 19:49 ` Antoine Terrienne
2005-03-26 20:09 ` Marco Gerards
2005-03-26 13:40 ` Marco Gerards
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200503222120.43235.okuji@enbug.org \
--to=okuji@enbug.org \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.