From: "David S. Miller" <davem@davemloft.net>
To: Dean Nelson <dcn@sgi.com>
Cc: tony.luck@intel.com, netdev@oss.sgi.com, linux-ia64@vger.kernel.org
Subject: Re: [PATCH 3/3] SGI Altix cross partition functionality (2nd
Date: Wed, 23 Mar 2005 20:02:48 +0000 [thread overview]
Message-ID: <20050323120248.03755d6b.davem@davemloft.net> (raw)
In-Reply-To: <20050323195139.GC21418@sgi.com>
On Wed, 23 Mar 2005 13:51:39 -0600
Dean Nelson <dcn@sgi.com> wrote:
> This patch contains the cross partition pseudo-ethernet driver (XPNET)
> functional support module.
>
> Signed-off-by: Dean Nelson <dcn@sgi.com>
Only a NIT or two. You should be setting the last_rx
value. Also, NETIF_F_HIGHDMA is pointless unless you
support NETIF_F_SG and thus paged SKBs. skb->data will
never be placed in high memory, only non-linear SKB
scatterlist pages will.
I should probably add a debugging check at device
registration time, like we already do to make sure
NETIF_F_SG is not set unless some checksumming
capability is there as well.
WARNING: multiple messages have this Message-ID (diff)
From: "David S. Miller" <davem@davemloft.net>
To: Dean Nelson <dcn@sgi.com>
Cc: tony.luck@intel.com, netdev@oss.sgi.com, linux-ia64@vger.kernel.org
Subject: Re: [PATCH 3/3] SGI Altix cross partition functionality (2nd revision)
Date: Wed, 23 Mar 2005 12:02:48 -0800 [thread overview]
Message-ID: <20050323120248.03755d6b.davem@davemloft.net> (raw)
In-Reply-To: <20050323195139.GC21418@sgi.com>
On Wed, 23 Mar 2005 13:51:39 -0600
Dean Nelson <dcn@sgi.com> wrote:
> This patch contains the cross partition pseudo-ethernet driver (XPNET)
> functional support module.
>
> Signed-off-by: Dean Nelson <dcn@sgi.com>
Only a NIT or two. You should be setting the last_rx
value. Also, NETIF_F_HIGHDMA is pointless unless you
support NETIF_F_SG and thus paged SKBs. skb->data will
never be placed in high memory, only non-linear SKB
scatterlist pages will.
I should probably add a debugging check at device
registration time, like we already do to make sure
NETIF_F_SG is not set unless some checksumming
capability is there as well.
next prev parent reply other threads:[~2005-03-23 20:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-23 19:29 [PATCH 0/3] SGI Altix cross partition functionality (2nd Dean Nelson
2005-03-23 19:29 ` [PATCH 0/3] SGI Altix cross partition functionality (2nd revision) Dean Nelson
2005-03-23 19:45 ` [PATCH 1/3] " Dean Nelson
2005-03-23 19:45 ` Dean Nelson
2005-03-23 19:50 ` [PATCH 2/3] " Dean Nelson
2005-03-23 19:50 ` Dean Nelson
2005-03-23 19:51 ` [PATCH 3/3] " Dean Nelson
2005-03-23 19:51 ` Dean Nelson
2005-03-23 20:02 ` David S. Miller [this message]
2005-03-23 20:02 ` David S. Miller
2005-03-23 20:50 ` Dean Nelson
2005-03-23 20:54 ` [PATCH 3/3] SGI Altix cross partition functionality (2nd David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050323120248.03755d6b.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dcn@sgi.com \
--cc=linux-ia64@vger.kernel.org \
--cc=netdev@oss.sgi.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.