All of lore.kernel.org
 help / color / mirror / Atom feed
From: khali@linux-fr.org (Jean Delvare)
To: Corey Minyard <cminyard@mvista.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	LM Sensors <sensors@stimpy.netroedge.com>,
	Greg KH <greg@kroah.com>
Subject: [PATCH] I2C Part 1 - Remove some redundancy from the i2c-core.c
Date: Thu, 19 May 2005 06:25:45 +0000	[thread overview]
Message-ID: <20050323224430.634e0a75.khali@linux-fr.org> (raw)
In-Reply-To: <42418B36.5030407@mvista.com>

Hi Corey,

> Call i2c_transfer() from i2c_master_send() and i2c_master_recv()
> to avoid the redundant code that was in all three functions.

I like this. You're right, there is code duplication here, which we can
get rid of, so let's do so. I'd only have one comments about your patch:

You can get rid of the dev_dbg calls in i2c_master_send() and
i2c_master_recv() altogether IMHO. I recently updated i2c_transfer() to
make it more verbose in debug mode [1], so the debug messages in
i2c_master_send() and i2c_master_recv() are mostly redundant now as far
as I can see.

[1] http://archives.andrew.net.au/lm-sensors/msg29859.html

Thanks,
-- 
Jean Delvare

WARNING: multiple messages have this Message-ID (diff)
From: Jean Delvare <khali@linux-fr.org>
To: Corey Minyard <cminyard@mvista.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	LM Sensors <sensors@stimpy.netroedge.com>,
	Greg KH <greg@kroah.com>
Subject: Re: [PATCH] I2C Part 1 - Remove some redundancy from the i2c-core.c file
Date: Wed, 23 Mar 2005 22:44:30 +0100	[thread overview]
Message-ID: <20050323224430.634e0a75.khali@linux-fr.org> (raw)
In-Reply-To: <42418B36.5030407@mvista.com>

Hi Corey,

> Call i2c_transfer() from i2c_master_send() and i2c_master_recv()
> to avoid the redundant code that was in all three functions.

I like this. You're right, there is code duplication here, which we can
get rid of, so let's do so. I'd only have one comments about your patch:

You can get rid of the dev_dbg calls in i2c_master_send() and
i2c_master_recv() altogether IMHO. I recently updated i2c_transfer() to
make it more verbose in debug mode [1], so the debug messages in
i2c_master_send() and i2c_master_recv() are mostly redundant now as far
as I can see.

[1] http://archives.andrew.net.au/lm-sensors/msg29859.html

Thanks,
-- 
Jean Delvare

  reply	other threads:[~2005-05-19  6:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-23 15:28 [PATCH] I2C Part 1 - Remove some redundancy from the i2c-core.c file Corey Minyard
2005-05-19  6:25 ` Corey Minyard
2005-03-23 21:44 ` Jean Delvare [this message]
2005-05-19  6:25   ` [PATCH] I2C Part 1 - Remove some redundancy from the i2c-core.c Jean Delvare
2005-03-31 22:03   ` [PATCH] I2C Part 1 - Remove some redundancy from the i2c-core.c file Corey Minyard
2005-05-19  6:25     ` [PATCH] I2C Part 1 - Remove some redundancy from the i2c-core.c Corey Minyard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050323224430.634e0a75.khali@linux-fr.org \
    --to=khali@linux-fr.org \
    --cc=cminyard@mvista.com \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sensors@stimpy.netroedge.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.