From: Adrian Bunk <bunk-HeJ8Db2Gnd6zQB+pC5nmwQ@public.gmane.org>
To: len.brown-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org
Cc: acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: drivers/acpi/scan.c: inconsequent NULL handling
Date: Thu, 24 Mar 2005 21:41:09 +0100 [thread overview]
Message-ID: <20050324204109.GC3966@stusta.de> (raw)
The Coverity checker found the following:
<-- snip -->
static int
acpi_bus_match (
struct acpi_device *device,
struct acpi_driver *driver)
{
if (driver && driver->ops.match)
return driver->ops.match(device, driver);
return acpi_match_ids(device, driver->ids);
}
<-- snip -->
Either driver can be NULL, in which case the driver->ids is a possible
NULL pointer reference, or it can't, in which case the check whether
it's NULL is superfluous.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
WARNING: multiple messages have this Message-ID (diff)
From: Adrian Bunk <bunk@stusta.de>
To: len.brown@intel.com
Cc: acpi-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: drivers/acpi/scan.c: inconsequent NULL handling
Date: Thu, 24 Mar 2005 21:41:09 +0100 [thread overview]
Message-ID: <20050324204109.GC3966@stusta.de> (raw)
The Coverity checker found the following:
<-- snip -->
static int
acpi_bus_match (
struct acpi_device *device,
struct acpi_driver *driver)
{
if (driver && driver->ops.match)
return driver->ops.match(device, driver);
return acpi_match_ids(device, driver->ids);
}
<-- snip -->
Either driver can be NULL, in which case the driver->ids is a possible
NULL pointer reference, or it can't, in which case the check whether
it's NULL is superfluous.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next reply other threads:[~2005-03-24 20:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-24 20:41 Adrian Bunk [this message]
2005-03-24 20:41 ` drivers/acpi/scan.c: inconsequent NULL handling Adrian Bunk
-- strict thread matches above, loose matches on Subject: below --
2006-01-06 16:29 Adrian Bunk
2006-01-06 19:36 ` Alexey Dobriyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050324204109.GC3966@stusta.de \
--to=bunk-hej8db2gnd6zqb+pc5nmwq@public.gmane.org \
--cc=acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=len.brown-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.