From: Adrian Bunk <bunk@stusta.de>
To: dtor_core@ameritech.net
Cc: linux-input@atrey.karlin.mff.cuni.cz, vojtech@suse.cz,
linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] drivers/input/serio/libps2.c: ps2_command: add a missing check
Date: Fri, 25 Mar 2005 01:11:06 +0100 [thread overview]
Message-ID: <20050325001106.GE3966@stusta.de> (raw)
In-Reply-To: <d120d5000503241339b0b5312@mail.gmail.com>
On Thu, Mar 24, 2005 at 04:39:31PM -0500, Dmitry Torokhov wrote:
>
> Yes, if it will make the checker happy. Although I (and this is
> probably just me) use BUG_ON only if kernel would not OOPS otherwise,
> to avoid scribbling over random memory and such.
I don't whether it would make the checker happy (and I don't care much).
It would IMHO make the code better understandable.
But I don't have a very strong opinion on this issue.
> Dmitry
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
prev parent reply other threads:[~2005-03-25 0:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-24 3:14 [2.6 patch] drivers/input/serio/libps2.c: ps2_command: add a missing check Adrian Bunk
2005-03-24 5:13 ` Dmitry Torokhov
2005-03-24 21:26 ` Adrian Bunk
2005-03-24 21:39 ` Dmitry Torokhov
2005-03-25 0:11 ` Adrian Bunk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050325001106.GE3966@stusta.de \
--to=bunk@stusta.de \
--cc=dtor_core@ameritech.net \
--cc=linux-input@atrey.karlin.mff.cuni.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=vojtech@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.