From: Adrian Bunk <bunk@stusta.de>
To: Benoit Boissinot <bboissin@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] sound/oss/: cleanups
Date: Tue, 29 Mar 2005 00:03:07 +0200 [thread overview]
Message-ID: <20050328220307.GO4285@stusta.de> (raw)
In-Reply-To: <40f323d00503281255124bd0c8@mail.gmail.com>
On Mon, Mar 28, 2005 at 03:55:36PM -0500, Benoit Boissinot wrote:
> On Sun, 6 Mar 2005 23:07:47 +0100, Adrian Bunk <bunk@stusta.de> wrote:
> > This patch contains cleanups including the following:
> > - make needlessly global code static
> >
> > Signed-off-by: Adrian Bunk <bunk@stusta.de>
> >
> > --- linux-2.6.11-mm1-full/sound/oss/nm256_audio.c.old 2005-03-06 22:14:42.000000000 +0100
> > +++ linux-2.6.11-mm1-full/sound/oss/nm256_audio.c 2005-03-06 22:22:52.000000000 +0100
> > @@ -31,7 +31,7 @@
> > #include "nm256.h"
> > #include "nm256_coeff.h"
> >
> > -int nm256_debug;
> > +static int nm256_debug;
> > static int force_load;
> >
> > /*
>
> nm256_debug is used in functions declared in nm256.h (those functions
> are used in nm256_coeff.h and nm256_audio.c).
The usage in nm256_audio.c is clear (the variable is in this file).
In which other .c file did you find any usage of nm256_debug?
> This part of the patch should be dropped (it doesn't build on gcc-4.0).
That's a different problem.
Please apply the patch below on top of my other patch.
> regards,
>
> Benoit
<-- snip -->
Rearrange sound/oss/nm256_audio.c and to drop nm256_debug from nm256.h
since it confuses gcc 4.0 .
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.12-rc1-mm3-full/sound/oss/nm256.h.old 2005-03-28 23:49:39.000000000 +0200
+++ linux-2.6.12-rc1-mm3-full/sound/oss/nm256.h 2005-03-28 23:51:33.000000000 +0200
@@ -128,9 +128,6 @@
struct nm256_info *next_card;
};
-/* Debug flag--bigger numbers mean more output. */
-extern int nm256_debug;
-
/* The BIOS signature. */
#define NM_SIGNATURE 0x4e4d0000
/* Signature mask. */
--- linux-2.6.12-rc1-mm3-full/sound/oss/nm256_audio.c.old 2005-03-28 23:51:53.000000000 +0200
+++ linux-2.6.12-rc1-mm3-full/sound/oss/nm256_audio.c 2005-03-28 23:52:19.000000000 +0200
@@ -28,12 +28,13 @@
#include <linux/delay.h>
#include <linux/spinlock.h>
#include "sound_config.h"
-#include "nm256.h"
-#include "nm256_coeff.h"
static int nm256_debug;
static int force_load;
+#include "nm256.h"
+#include "nm256_coeff.h"
+
/*
* The size of the playback reserve. When the playback buffer has less
* than NM256_PLAY_WMARK_SIZE bytes to output, we request a new
next prev parent reply other threads:[~2005-03-28 22:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-06 22:07 [2.6 patch] sound/oss/: cleanups Adrian Bunk
2005-03-28 20:55 ` Benoit Boissinot
2005-03-28 22:03 ` Adrian Bunk [this message]
2005-03-31 21:34 ` Benoit Boissinot
-- strict thread matches above, loose matches on Subject: below --
2005-03-24 3:09 Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050328220307.GO4285@stusta.de \
--to=bunk@stusta.de \
--cc=bboissin@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.