All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benoit Boissinot <bboissin@gmail.com>
To: Adrian Bunk <bunk@stusta.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] sound/oss/: cleanups
Date: Mon, 28 Mar 2005 15:55:36 -0500	[thread overview]
Message-ID: <40f323d00503281255124bd0c8@mail.gmail.com> (raw)
In-Reply-To: <20050306220747.GP5070@stusta.de>

On Sun, 6 Mar 2005 23:07:47 +0100, Adrian Bunk <bunk@stusta.de> wrote:
> This patch contains cleanups including the following:
> - make needlessly global code static
> 
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
> 
> --- linux-2.6.11-mm1-full/sound/oss/nm256_audio.c.old   2005-03-06 22:14:42.000000000 +0100
> +++ linux-2.6.11-mm1-full/sound/oss/nm256_audio.c       2005-03-06 22:22:52.000000000 +0100
> @@ -31,7 +31,7 @@
>  #include "nm256.h"
>  #include "nm256_coeff.h"
> 
> -int nm256_debug;
> +static int nm256_debug;
>  static int force_load;
> 
>  /*

nm256_debug is used in functions declared in nm256.h (those functions
are used in nm256_coeff.h and nm256_audio.c).
This part of the patch should be dropped (it doesn't build on gcc-4.0).

regards,

Benoit

  reply	other threads:[~2005-03-28 20:59 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-06 22:07 [2.6 patch] sound/oss/: cleanups Adrian Bunk
2005-03-28 20:55 ` Benoit Boissinot [this message]
2005-03-28 22:03   ` Adrian Bunk
2005-03-31 21:34     ` Benoit Boissinot
  -- strict thread matches above, loose matches on Subject: below --
2005-03-24  3:09 Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=40f323d00503281255124bd0c8@mail.gmail.com \
    --to=bboissin@gmail.com \
    --cc=bunk@stusta.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.