From: Christoph Hellwig <hch@lst.de>
To: Andrew Morton <akpm@osdl.org>
Cc: Christoph Hellwig <hch@lst.de>,
wendyx@us.ltcfwd.linux.ibm.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fixup newly added jsm driver
Date: Wed, 30 Mar 2005 08:41:45 +0200 [thread overview]
Message-ID: <20050330064145.GA12571@lst.de> (raw)
In-Reply-To: <20050329134734.71c16b54.akpm@osdl.org>
On Tue, Mar 29, 2005 at 01:47:34PM -0800, Andrew Morton wrote:
> Christoph Hellwig <hch@lst.de> wrote:
> >
> > One more prematurely added drivers..
>
> This driver was first sent out for review a month ago, was upissued twice
> and generated over seventy linux-kernel emails including some from Russell
> and some from Greg. It was by no means a "premature" addition.
>
> One could say that it was inadequately reviewed, but how is one to
> determine that? If the thing has been under discussion for a month and the
> submitter says "I've addressed all comments" then it's going to get merged.
I don't think the submitter should say all issues have been addressed
but that should come from a sufficiently trusted reviewer.
prev parent reply other threads:[~2005-03-30 6:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-29 21:07 [PATCH] fixup newly added jsm driver Christoph Hellwig
2005-03-29 21:47 ` Andrew Morton
2005-03-29 22:56 ` Jeff Garzik
2005-03-30 6:42 ` Christoph Hellwig
2005-03-30 6:41 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050330064145.GA12571@lst.de \
--to=hch@lst.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wendyx@us.ltcfwd.linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.