All of lore.kernel.org
 help / color / mirror / Atom feed
* Improve POM error message
@ 2005-03-30 15:01 Wang Jian
  2005-04-01  7:05 ` Harald Welte
  0 siblings, 1 reply; 2+ messages in thread
From: Wang Jian @ 2005-03-30 15:01 UTC (permalink / raw)
  To: netfilter-devel

Hi,

Here is a one liner patch agains Netfilter_POM.pm which improves error
message. This patch will give more clear information in the situation
that there are multiple lineadd files for a single file.


Index: Netfilter_POM.pm
===================================================================
--- Netfilter_POM.pm    (revision 3808)
+++ Netfilter_POM.pm    (working copy)
@@ -630,7 +630,7 @@
        close(SRC);
                
        if ($found == 0) {
-               $self->{ERRMSG} .= "unable to find ladd slot in src $srcfile\n";
+               $self->{ERRMSG} .= "unable to find ladd slot in src $srcfile ($laddfile)\n";
                return 0;
        } elsif (!$test && $found == -1) {
                $self->{ERRMSG} .= "unable to find all to-be-removed lines in $srcfile\n";



-- 
  lark

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Improve POM error message
  2005-03-30 15:01 Improve POM error message Wang Jian
@ 2005-04-01  7:05 ` Harald Welte
  0 siblings, 0 replies; 2+ messages in thread
From: Harald Welte @ 2005-04-01  7:05 UTC (permalink / raw)
  To: Wang Jian; +Cc: netfilter-devel

[-- Attachment #1: Type: text/plain, Size: 675 bytes --]

On Wed, Mar 30, 2005 at 11:01:55PM +0800, Wang Jian wrote:
> Hi,
> 
> Here is a one liner patch agains Netfilter_POM.pm which improves error
> message. This patch will give more clear information in the situation
> that there are multiple lineadd files for a single file.

thanks, patch applied.
-- 
- Harald Welte <laforge@netfilter.org>                 http://netfilter.org/
============================================================================
  "Fragmentation is like classful addressing -- an interesting early
   architectural error that shows how much experimentation was going
   on while IP was being designed."                    -- Paul Vixie

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2005-04-01  7:05 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-03-30 15:01 Improve POM error message Wang Jian
2005-04-01  7:05 ` Harald Welte

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.