[linux-lvm] [PATCH] --ignorelockingfailure for `lvm mkvgnodes`

[linux-lvm] [PATCH] --ignorelockingfailure for `lvm mkvgnodes`

[Tomasz Torcz]

[-- Attachment #1: Type: text/plain, Size: 849 bytes --]


 Hi,

 `lvm vgmknodes` needs --ignorevglocking. Consider following scenario:
- just after initrd finishes, everything is activated
- /dev is mount as tmpfs, read-write, managed by udev
- other filesystem hovewer are mounted read-only
  - /var could be not mounted at all!

- filesystem are going to be remounted rw after fsck. But fsck won't
  run, as there are LVM nodes missing from /dev. fsck error == fatal
  condition
- lvm vgmknodes won't run, because it can't obtain lock in /var. But
  should work, as /dev is writable

 Attached trivial patch adds --ignorelockingfailure to vgmknodes. It is
pretty safe.

 I've ecnountered above scenario on Slackware system during migration to
LVM2.

-- 
Tomasz Torcz               "Never underestimate the bandwidth of a station
zdzichu@irc.-nie.spam-.pl    wagon filled with backup tapes." -- Jim Gray


[-- Attachment #2: vgmknodes-ignorelockingfailure.diff --]
[-- Type: text/plain, Size: 528 bytes --]

diff -ru LVM2.old/tools/commands.h LVM2.new/tools/commands.h
--- LVM2.old/tools/commands.h	2005-04-03 12:08:05.000000000 +0200
+++ LVM2.new/tools/commands.h	2005-04-03 12:29:17.000000000 +0200
@@ -717,9 +717,12 @@
    "vgmknodes\n"
    "\t[-d|--debug]\n"
    "\t[-h|--help]\n"
+   "\t[--ignorelockingfailure]\n"
    "\t[-v|--verbose]\n"
    "\t[--version]" "\n"
-   "\t[VolumeGroupName...]\n" )
+   "\t[VolumeGroupName...]\n",
+
+   ignorelockingfailure_ARG)
 
 xx(vgreduce,
    "Remove physical volume(s) from a volume group",

Re: [linux-lvm] [PATCH] --ignorelockingfailure for `lvm mkvgnodes`

[Alasdair G Kergon]

On Sun, Apr 03, 2005 at 12:41:58PM +0200, Tomasz Torcz wrote:
>  `lvm vgmknodes` needs --ignorevglocking

Agreed - though for different reasons (I won't go into here).

'vgscan --mknodes --ignorelockingfailure' is normally adequate, and looks 
to be so in your case?

Alasdair
-- 
agk@redhat.com

Re: [linux-lvm] [PATCH] --ignorelockingfailure for `lvm mkvgnodes`

[Luca Berra]

[-- Attachment #1: Type: text/plain, Size: 593 bytes --]

On Sun, Apr 03, 2005 at 08:42:07PM +0100, Alasdair G Kergon wrote:
>On Sun, Apr 03, 2005 at 12:41:58PM +0200, Tomasz Torcz wrote:
>>  `lvm vgmknodes` needs --ignorevglocking
>
>Agreed - though for different reasons (I won't go into here).
>
>'vgscan --mknodes --ignorelockingfailure' is normally adequate, and looks 
>to be so in your case?
>
so you mean
vgscan
vgchange -a y
vgscan --mknodes
???

Btw, i added man page to Tomasz patch

L.


-- 
Luca Berra -- bluca@comedia.it
        Communication Media & Services S.r.l.
 /"\
 \ /     ASCII RIBBON CAMPAIGN
  X        AGAINST HTML MAIL
 / \

[-- Attachment #2: lvm2-ignorelock.patch.bz2 --]
[-- Type: application/octet-stream, Size: 633 bytes --]