From: Domen Puncer <domen@coderock.org>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] [PATCH] char* : drivers/char/agp/intel-agp.c
Date: Mon, 04 Apr 2005 11:37:46 +0000 [thread overview]
Message-ID: <20050404113746.GD7891@nd47.coderock.org> (raw)
In-Reply-To: <20050401122030.GM5445@rhum.iomeda.fr>
[-- Attachment #1: Type: text/plain, Size: 772 bytes --]
On 01/04/05 14:20 +0200, Christophe Lucas wrote:
> Description:
> String form : char foo[] = "blah" is better than char *foo = "blah"
>
> Signed-off-by: Christophe Lucas <clucas@rotomalug.org>
> diff -urpN -X dontdiff a/drivers/char/agp/intel-agp.c b/drivers/char/agp/intel-agp.c
> --- a/drivers/char/agp/intel-agp.c 2005-03-18 02:34:12.000000000 +0100
> +++ b/drivers/char/agp/intel-agp.c 2005-04-01 12:08:36.751735144 +0200
> @@ -1532,7 +1532,7 @@ static int __devinit agp_intel_probe(str
> const struct pci_device_id *ent)
> {
> struct agp_bridge_data *bridge;
> - char *name = "(unknown)";
> + char name[] = "(unknown)";
A few lines below there's a
name = "440LX";
... so i don't think this will even compile.
Same goes for next, acpi patch.
Domen
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
prev parent reply other threads:[~2005-04-04 11:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-01 12:20 [KJ] [PATCH] char* : drivers/char/agp/intel-agp.c Christophe Lucas
2005-04-04 11:37 ` Domen Puncer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050404113746.GD7891@nd47.coderock.org \
--to=domen@coderock.org \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.