From: Dave Jones <davej@redhat.com>
To: Ian Pratt <m+Ian.Pratt@cl.cam.ac.uk>
Cc: xen-devel@lists.xensource.com
Subject: Re: [PATCH] incorrect memset usage.
Date: Tue, 5 Apr 2005 12:19:23 -0400 [thread overview]
Message-ID: <20050405161923.GA8006@redhat.com> (raw)
In-Reply-To: <A95E2296287EAD4EB592B5DEEFCE0E9D1E3A2D@liverpoolst.ad.cl.cam.ac.uk>
On Tue, Apr 05, 2005 at 07:58:52AM +0100, Ian Pratt wrote:
>
> I think these have already been applied, no?
> Thanks,
> Ian
Only in the unstable tree.
This one..
> > --- xen-2.0.bk/tools/libxutil/sys_net.c~ 2005-03-31
> > 01:11:27.852264603 -0500
> > +++ xen-2.0.bk/tools/libxutil/sys_net.c 2005-03-31
> > 01:11:39.320054735 -0500
> > @@ -310,7 +310,7 @@ char *mac_ntoa(const unsigned char *mac)
> > static char buf[MAC_LENGTH + 1];
> > int buf_n = sizeof(buf);
> >
> > - memset(buf, buf_n, 0);
> > + memset(buf, 0, buf_n);
> > snprintf(buf, buf_n, "%02x:%02x:%02x:%02x:%02x:%02x",
> > mac[0], mac[1], mac[2],
> > mac[3], mac[4], mac[5]);
> >
Still isn't it seems..
(12:16:09:davej@mesh:xen-2.0.bk)$ bk pull
Pull bk://xen.bkbits.net/xen-2.0.bk
-> file://home/davej/xen-2.0.bk
Nothing to pull.
Dave
next prev parent reply other threads:[~2005-04-05 16:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-05 6:58 [PATCH] incorrect memset usage Ian Pratt
2005-04-05 16:19 ` Dave Jones [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-03-31 6:21 Dave Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050405161923.GA8006@redhat.com \
--to=davej@redhat.com \
--cc=m+Ian.Pratt@cl.cam.ac.uk \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.