2.6.12-rc2 compile error in drivers/usb/class/cdc-acm.c

2.6.12-rc2 compile error in drivers/usb/class/cdc-acm.c

[Ben Castricum]

2.6.12-rc1 compiles and runs perfectly.

gcc version 2.95.3 20010315 (release)

  CC [M]  drivers/usb/class/cdc-acm.o
In file included from drivers/usb/class/cdc-acm.c:63:
include/linux/usb_cdc.h:117: field `bDetailData' has incomplete type
make[3]: *** [drivers/usb/class/cdc-acm.o] Error 1
make[2]: *** [drivers/usb/class] Error 2
make[1]: *** [drivers/usb] Error 2
make: *** [drivers] Error 2


I also get several warnings while compiling the kernel:


  CC      fs/quota_v2.o
fs/quota_v2.c: In function `v2_write_dquot':
fs/quota_v2.c:399: warning: unknown conversion type character `z' in
format
fs/quota_v2.c:399: warning: too many arguments for format

  CC [M]  drivers/acpi/processor_idle.o
drivers/acpi/processor_idle.c: In function
`acpi_processor_power_seq_show':
drivers/acpi/processor_idle.c:868: warning: unknown conversion type
character `z' in format
drivers/acpi/processor_idle.c:868: warning: too many arguments for format
drivers/acpi/processor_idle.c:899: warning: unknown conversion type
character `z' in format
drivers/acpi/processor_idle.c:899: warning: too many arguments for format
drivers/acpi/processor_idle.c:906: warning: unknown conversion type
character `z' in format
drivers/acpi/processor_idle.c:906: warning: too many arguments for format

my .config can be found at

http://www.bencastricum.nl/.config

Hope this helps,
Ben

Re: 2.6.12-rc2 compile error in drivers/usb/class/cdc-acm.c

[Adrian Bunk]

On Tue, Apr 05, 2005 at 10:54:09AM +0200, Ben Castricum wrote:
> 
> 2.6.12-rc1 compiles and runs perfectly.
> 
> gcc version 2.95.3 20010315 (release)
> 
>   CC [M]  drivers/usb/class/cdc-acm.o
> In file included from drivers/usb/class/cdc-acm.c:63:
> include/linux/usb_cdc.h:117: field `bDetailData' has incomplete type
> make[3]: *** [drivers/usb/class/cdc-acm.o] Error 1
> make[2]: *** [drivers/usb/class] Error 2
> make[1]: *** [drivers/usb] Error 2
> make: *** [drivers] Error 2


That's a known problem already fixed in -mm.


> I also get several warnings while compiling the kernel:
> 
> 
>   CC      fs/quota_v2.o
> fs/quota_v2.c: In function `v2_write_dquot':
> fs/quota_v2.c:399: warning: unknown conversion type character `z' in
> format
> fs/quota_v2.c:399: warning: too many arguments for format
> 
>   CC [M]  drivers/acpi/processor_idle.o
> drivers/acpi/processor_idle.c: In function
> `acpi_processor_power_seq_show':
> drivers/acpi/processor_idle.c:868: warning: unknown conversion type
> character `z' in format
> drivers/acpi/processor_idle.c:868: warning: too many arguments for format
> drivers/acpi/processor_idle.c:899: warning: unknown conversion type
> character `z' in format
> drivers/acpi/processor_idle.c:899: warning: too many arguments for format
> drivers/acpi/processor_idle.c:906: warning: unknown conversion type
> character `z' in format
> drivers/acpi/processor_idle.c:906: warning: too many arguments for format
>...


These are warnings that only occur with gcc 2.95 and that can safely be
ignored.


> Hope this helps,
> Ben


cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: 2.6.12-rc2 compile error in drivers/usb/class/cdc-acm.c

[Ben Castricum]

On Wed, 6 Apr 2005, Adrian Bunk wrote:

> On Tue, Apr 05, 2005 at 10:54:09AM +0200, Ben Castricum wrote:
> > ...
> >   CC      fs/quota_v2.o
> > fs/quota_v2.c: In function `v2_write_dquot':
> > fs/quota_v2.c:399: warning: unknown conversion type character `z' in
> > format
> > fs/quota_v2.c:399: warning: too many arguments for format
>
> These are warnings that only occur with gcc 2.95 and that can safely be
> ignored.

Just wondering, isn't 2.95.3 the recommended compiler anymore? I only use
this (a bit old) version because it's _the_ compiler for the kernel.

If it still is then I find it a bit strange that code is accepted that
doesn't compile cleanly on the recommended compiler.

Thanks for your help,
Ben

Re: 2.6.12-rc2 compile error in drivers/usb/class/cdc-acm.c

[Andrew Morton]

Ben Castricum <benc@bencastricum.nl> wrote:
>
> 
> 
> On Wed, 6 Apr 2005, Adrian Bunk wrote:
> 
> > On Tue, Apr 05, 2005 at 10:54:09AM +0200, Ben Castricum wrote:
> > > ...
> > >   CC      fs/quota_v2.o
> > > fs/quota_v2.c: In function `v2_write_dquot':
> > > fs/quota_v2.c:399: warning: unknown conversion type character `z' in
> > > format
> > > fs/quota_v2.c:399: warning: too many arguments for format
> >
> > These are warnings that only occur with gcc 2.95 and that can safely be
> > ignored.
> 
> Just wondering, isn't 2.95.3 the recommended compiler anymore? I only use
> this (a bit old) version because it's _the_ compiler for the kernel.
> 
> If it still is then I find it a bit strange that code is accepted that
> doesn't compile cleanly on the recommended compiler.
> 

gcc-2.95.x requires %Z, not %z.  The latter is more correct, and not many
people use gcc-2.95.x, so we'll just have to live with the warnings, I'm
afraid.

I patched my gcc-2.95.4 to understand %z, but seem to have not put the
patch anywhere where I can find it.

Re: 2.6.12-rc2 compile error in drivers/usb/class/cdc-acm.c

[Adrian Bunk]

On Wed, Apr 06, 2005 at 10:22:50AM +0200, Ben Castricum wrote:
>...
> Just wondering, isn't 2.95.3 the recommended compiler anymore? I only use
> this (a bit old) version because it's _the_ compiler for the kernel.
>...

GNU gcc 2.95 is still a supported compiler (although the number of 
people using it seems to be steadily decreasing).

There's no clearly defined "recommended" compiler today.

cu
Adrian

--

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed