From: Tobias Klauser <tklauser@nuerscht.ch>
To: kernel-janitors@vger.kernel.org
Subject: [KJ] Re: [PATCH] arch/ppc64: Replace custom MIN macro
Date: Fri, 08 Apr 2005 09:33:44 +0000 [thread overview]
Message-ID: <20050408093344.GA834@neon> (raw)
In-Reply-To: <16981.48000.586005.656966@cargo.ozlabs.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 728 bytes --]
On Fri, Apr 08, 2005 at 09:00:16AM +1000, Paul Mackerras wrote:
> Tobias Klauser writes:
>
> > >From the kerneljanitors TODO list:
> > - min/max macros from kernel.h are safe, a lot of handcrafted MIN/MAX are not.
>
> Well... OK, that removes 4 lines of code, which is good, but the
> explanation needs changing - it's not a question of safety, it doesn't
> matter if we evaluate sizeof() more than once. :)
min/max from kernel.h also do type checking, so the compiler throws out
warnings in case of mismatching types, although this doesn't matter for
this patch.
So how about the following description:
Replace a custom MIN() macro with the min() macro from kernel.h
This patch removes 4 lines of redundant code.
Tobias
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
prev parent reply other threads:[~2005-04-08 9:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-07 23:00 [KJ] Re: [PATCH] arch/ppc64: Replace custom MIN macro Paul Mackerras
2005-04-08 9:33 ` Tobias Klauser [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050408093344.GA834@neon \
--to=tklauser@nuerscht.ch \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.