[KJ] Re: [PATCH] arch/ppc64: Replace custom MIN macro

[KJ] Re: [PATCH] arch/ppc64: Replace custom MIN macro

[Paul Mackerras]

[-- Attachment #1: Type: text/plain, Size: 337 bytes --]

Tobias Klauser writes:

> >From the kerneljanitors TODO list:
> - min/max macros from kernel.h are safe, a lot of handcrafted MIN/MAX are not.

Well... OK, that removes 4 lines of code, which is good, but the
explanation needs changing - it's not a question of safety, it doesn't
matter if we evaluate sizeof() more than once. :)

Paul.

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

[KJ] Re: [PATCH] arch/ppc64: Replace custom MIN macro

[Tobias Klauser]

[-- Attachment #1: Type: text/plain, Size: 728 bytes --]

On Fri, Apr 08, 2005 at 09:00:16AM +1000, Paul Mackerras wrote:
> Tobias Klauser writes:
> 
> > >From the kerneljanitors TODO list:
> > - min/max macros from kernel.h are safe, a lot of handcrafted MIN/MAX are not.
> 
> Well... OK, that removes 4 lines of code, which is good, but the
> explanation needs changing - it's not a question of safety, it doesn't
> matter if we evaluate sizeof() more than once. :)

min/max from kernel.h also do type checking, so the compiler throws out
warnings in case of mismatching types, although this doesn't matter for
this patch.

So how about the following description:

Replace a custom MIN() macro with the min() macro from kernel.h
This patch removes 4 lines of redundant code.

	Tobias

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors