From: Greg KH <gregkh@suse.de>
To: Roland Dreier <roland@topspin.com>
Cc: gregkh@suse.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Reduce <linux/debugfs.h> dependencies
Date: Fri, 8 Apr 2005 15:18:02 -0700 [thread overview]
Message-ID: <20050408221801.GD3399@kroah.com> (raw)
In-Reply-To: <52ll87y9kl.fsf@topspin.com>
On Mon, Mar 28, 2005 at 09:16:58AM -0800, Roland Dreier wrote:
> The current <linux/debugfs.h> include file is a little fragile in that
> it is not self-contained and hence may cause compile warnings or
> errors depending on the files included before it, the kernel config
> and the architecture. This patch makes things a little more robust by:
>
> - including <linux/types.h> to get definitions of u32, mode_t, and so on.
> - forward declaring struct file_operations.
> - including <linux/err.h> when CONFIG_DEBUG_FS is not set
>
> The last change is particularly useful, as a kernel developer is
> likely to build with debugfs always enabled and never see the build
> breakage cased if debugfs is disabled.
>
> Signed-off-by: Roland Dreier <roland@topspin.com>
Applied, thanks.
greg k-h
prev parent reply other threads:[~2005-04-08 22:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-28 17:16 [PATCH] Reduce <linux/debugfs.h> dependencies Roland Dreier
2005-04-08 22:18 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050408221801.GD3399@kroah.com \
--to=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=roland@topspin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.