From: Roland Dreier <roland@topspin.com>
To: gregkh@suse.de
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] Reduce <linux/debugfs.h> dependencies
Date: Mon, 28 Mar 2005 09:16:58 -0800 [thread overview]
Message-ID: <52ll87y9kl.fsf@topspin.com> (raw)
The current <linux/debugfs.h> include file is a little fragile in that
it is not self-contained and hence may cause compile warnings or
errors depending on the files included before it, the kernel config
and the architecture. This patch makes things a little more robust by:
- including <linux/types.h> to get definitions of u32, mode_t, and so on.
- forward declaring struct file_operations.
- including <linux/err.h> when CONFIG_DEBUG_FS is not set
The last change is particularly useful, as a kernel developer is
likely to build with debugfs always enabled and never see the build
breakage cased if debugfs is disabled.
Signed-off-by: Roland Dreier <roland@topspin.com>
Index: linux-export/include/linux/debugfs.h
===================================================================
--- linux-export.orig/include/linux/debugfs.h 2005-01-10 11:48:00.000000000 -0800
+++ linux-export/include/linux/debugfs.h 2005-03-28 09:08:40.982161696 -0800
@@ -15,6 +15,10 @@
#ifndef _DEBUGFS_H_
#define _DEBUGFS_H_
+#include <linux/types.h>
+
+struct file_operations;
+
#if defined(CONFIG_DEBUG_FS)
struct dentry *debugfs_create_file(const char *name, mode_t mode,
struct dentry *parent, void *data,
@@ -34,6 +38,9 @@
struct dentry *parent, u32 *value);
#else
+
+#include <linux/err.h>
+
/*
* We do not return NULL from these functions if CONFIG_DEBUG_FS is not enabled
* so users have a chance to detect if there was a real error or not. We don't
next reply other threads:[~2005-03-28 17:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-28 17:16 Roland Dreier [this message]
2005-04-08 22:18 ` [PATCH] Reduce <linux/debugfs.h> dependencies Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52ll87y9kl.fsf@topspin.com \
--to=roland@topspin.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.