All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: "Artem B. Bityuckiy" <dedekind@infradead.org>
Cc: dwmw2@lists.infradead.org, linux-mtd@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATC] small VFS change for JFFS2
Date: Mon, 18 Apr 2005 09:51:21 +0100	[thread overview]
Message-ID: <20050418085121.GA19091@infradead.org> (raw)
In-Reply-To: <1113814031.31595.3.camel@sauron.oktetlabs.ru>

On Mon, Apr 18, 2005 at 12:47:11PM +0400, Artem B. Bityuckiy wrote:
> JFFS2 assumes that the above mentioned 'state' field is always coherent
> with the real state of the inode. The state is changed on read_inode()
> and clear_inode() inode operation calls.
 
> One obvious thing to fix this JFFS2 problem is to acquire the iprune_sem
> semaphore in JFFS2 GC, but for this we need to export it. So, please,
> consider the following VFS patch (against Linux 2.6.11.5):

No, exporting locks is a really bad idea.  Please try to find a better
method to fix your problem that doesn't export random kernel symbols.

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: "Artem B. Bityuckiy" <dedekind@infradead.org>
Cc: linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org,
	dwmw2@lists.infradead.org
Subject: Re: [PATC] small VFS change for JFFS2
Date: Mon, 18 Apr 2005 09:51:21 +0100	[thread overview]
Message-ID: <20050418085121.GA19091@infradead.org> (raw)
In-Reply-To: <1113814031.31595.3.camel@sauron.oktetlabs.ru>

On Mon, Apr 18, 2005 at 12:47:11PM +0400, Artem B. Bityuckiy wrote:
> JFFS2 assumes that the above mentioned 'state' field is always coherent
> with the real state of the inode. The state is changed on read_inode()
> and clear_inode() inode operation calls.
 
> One obvious thing to fix this JFFS2 problem is to acquire the iprune_sem
> semaphore in JFFS2 GC, but for this we need to export it. So, please,
> consider the following VFS patch (against Linux 2.6.11.5):

No, exporting locks is a really bad idea.  Please try to find a better
method to fix your problem that doesn't export random kernel symbols.


  reply	other threads:[~2005-04-18  8:51 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-18  8:47 [PATC] small VFS change for JFFS2 Artem B. Bityuckiy
2005-04-18  8:47 ` Artem B. Bityuckiy
2005-04-18  8:51 ` Christoph Hellwig [this message]
2005-04-18  8:51   ` Christoph Hellwig
2005-04-18  8:58   ` Artem B. Bityuckiy
2005-04-18  8:58     ` Artem B. Bityuckiy
2005-04-18 10:53     ` Christoph Hellwig
2005-04-18 10:53       ` Christoph Hellwig
2005-04-18 11:46       ` Artem B. Bityuckiy
2005-04-18 11:46         ` Artem B. Bityuckiy
2005-04-18 11:52         ` Christoph Hellwig
2005-04-18 11:52           ` Christoph Hellwig
2005-04-18 12:31           ` Artem B. Bityuckiy
2005-04-18 12:31             ` Artem B. Bityuckiy
2005-04-18 12:46             ` David Woodhouse
2005-04-18 12:46               ` David Woodhouse
2005-04-18 12:46             ` Christoph Hellwig
2005-04-18 12:46               ` Christoph Hellwig
2005-04-18 12:56               ` Artem B. Bityuckiy
2005-04-18 12:56                 ` Artem B. Bityuckiy
2005-04-18 13:08               ` David Woodhouse
2005-04-18 13:08                 ` David Woodhouse
2005-04-18 13:37                 ` ntfs ->iput use - was: " Anton Altaparmakov
2005-04-18 13:38                   ` Anton Altaparmakov
2005-04-18 13:16               ` David Woodhouse
2005-04-18 13:16                 ` David Woodhouse
2005-04-18 14:07                 ` Artem B. Bityuckiy
2005-04-18 14:07                   ` Artem B. Bityuckiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050418085121.GA19091@infradead.org \
    --to=hch@infradead.org \
    --cc=dedekind@infradead.org \
    --cc=dwmw2@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.