Re: [PATCH] Fix NAT TCP sequence adjustment

[Phil Oester <kernel@linuxace.com>]

On Wed, Apr 20, 2005 at 07:50:44PM +0200, Patrick McHardy wrote:
> >I'm aware of that, but again I claim that it is irrelevant in this case
> >because the PORT commands will not be processed out of order (even if the
> >data packets are), and thus the adjustments will occur sequentially.
> 
> Why wouldn't they be processed out of order by nat?

Because a second transfer will not be started until the first completes
in my experience.  Thus, there will not be two 'PORT' packets floating 
around to potentially arrive out of order

> I agree that the problem should be fixed ASAP. I'll do a proper fix
> now - either by moving seq adjustment after NAT helpers or by adding
> a flag to the skb.

Doesn't sound like a -stable fix, but whatever you think is best.

Phil