All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Warning: "nd_tbl" [net/ipv6/netfilter/ip6t_ROUTE.ko] undefined!
@ 2005-04-22 11:31 Pawel Sikora
  2005-04-22 11:59 ` YOSHIFUJI Hideaki / 吉藤英明
  0 siblings, 1 reply; 4+ messages in thread
From: Pawel Sikora @ 2005-04-22 11:31 UTC (permalink / raw)
  To: Netfilter Developers

[-- Attachment #1: Type: text/plain, Size: 182 bytes --]

Hi,

Please apply attached patch.

Regards,
Pawel.

-- 
/* Copyright (C) 2003, SCO, Inc. This is valuable Intellectual Property. */

                           #define say(x) lie(x)

[-- Attachment #2: nd_tbl.patch --]
[-- Type: text/x-diff, Size: 387 bytes --]

Warning: "nd_tbl" [net/ipv6/netfilter/ip6t_ROUTE.ko] undefined!

--- a/net/ipv6/ipv6_syms.c	2005-04-22 13:18:01.000000000 +0200
+++ b/net/ipv6/ipv6_syms.c	2005-04-22 13:21:28.000000000 +0200
@@ -36,6 +36,7 @@
 #ifdef CONFIG_XFRM
 EXPORT_SYMBOL(xfrm6_rcv);
 #endif
+EXPORT_SYMBOL(nd_tbl);
 EXPORT_SYMBOL(rt6_lookup);
 EXPORT_SYMBOL(fl6_sock_lookup);
 EXPORT_SYMBOL(ipv6_push_nfrag_opts);

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Warning: "nd_tbl" [net/ipv6/netfilter/ip6t_ROUTE.ko] undefined!
  2005-04-22 11:31 [PATCH] Warning: "nd_tbl" [net/ipv6/netfilter/ip6t_ROUTE.ko] undefined! Pawel Sikora
@ 2005-04-22 11:59 ` YOSHIFUJI Hideaki / 吉藤英明
  2005-04-22 12:07   ` YOSHIFUJI Hideaki / 吉藤英明
  0 siblings, 1 reply; 4+ messages in thread
From: YOSHIFUJI Hideaki / 吉藤英明 @ 2005-04-22 11:59 UTC (permalink / raw)
  To: pluto; +Cc: netfilter-devel

In article <200504221331.27454.pluto@pld-linux.org> (at Fri, 22 Apr 2005 13:31:27 +0200), Pawel Sikora <pluto@pld-linux.org> says:

> Warning: "nd_tbl" [net/ipv6/netfilter/ip6t_ROUTE.ko] undefined!
> 
> --- a/net/ipv6/ipv6_syms.c	2005-04-22 13:18:01.000000000 +0200
> +++ b/net/ipv6/ipv6_syms.c	2005-04-22 13:21:28.000000000 +0200
> @@ -36,6 +36,7 @@
>  #ifdef CONFIG_XFRM
>  EXPORT_SYMBOL(xfrm6_rcv);
>  #endif
> +EXPORT_SYMBOL(nd_tbl);
>  EXPORT_SYMBOL(rt6_lookup);
>  EXPORT_SYMBOL(fl6_sock_lookup);
>  EXPORT_SYMBOL(ipv6_push_nfrag_opts);

I disagree. Please try not to use nd_tbl;
maybe, by making and exporting neigh_lookup().
Thanks.

-- 
Hideaki YOSHIFUJI @ USAGI Project <yoshfuji@linux-ipv6.org>
Homepage: http://www.yoshifuji.org/~hideaki/
GPG FP  : 9022 65EB 1ECF 3AD1 0BDF  80D8 4807 F894 E062 0EEA

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Warning: "nd_tbl" [net/ipv6/netfilter/ip6t_ROUTE.ko] undefined!
  2005-04-22 11:59 ` YOSHIFUJI Hideaki / 吉藤英明
@ 2005-04-22 12:07   ` YOSHIFUJI Hideaki / 吉藤英明
  2005-04-22 15:00     ` Pawel Sikora
  0 siblings, 1 reply; 4+ messages in thread
From: YOSHIFUJI Hideaki / 吉藤英明 @ 2005-04-22 12:07 UTC (permalink / raw)
  To: pluto; +Cc: netfilter-devel

In article <20050422.205957.47968472.yoshfuji@linux-ipv6.org> (at Fri, 22 Apr 2005 20:59:57 +0900 (JST)), YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@linux-ipv6.org> says:

> I disagree. Please try not to use nd_tbl;
> maybe, by making and exporting neigh_lookup().

Oops, ndisc_lookup().

-- 
Hideaki YOSHIFUJI @ USAGI Project <yoshfuji@linux-ipv6.org>
Homepage: http://www.yoshifuji.org/~hideaki/
GPG FP  : 9022 65EB 1ECF 3AD1 0BDF  80D8 4807 F894 E062 0EEA

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Warning: "nd_tbl" [net/ipv6/netfilter/ip6t_ROUTE.ko] undefined!
  2005-04-22 12:07   ` YOSHIFUJI Hideaki / 吉藤英明
@ 2005-04-22 15:00     ` Pawel Sikora
  0 siblings, 0 replies; 4+ messages in thread
From: Pawel Sikora @ 2005-04-22 15:00 UTC (permalink / raw)
  To: Netfilter Developers

On Friday 22 of April 2005 14:07, you wrote:

<yoshfuji@linux-ipv6.org> says:
> > I disagree. Please try not to use nd_tbl;
> > maybe, by making and exporting neigh_lookup().
>
> Oops, ndisc_lookup().

I dont see ndisc_lookup() in 2.6.11.7 sources.

ip6t_ROUTE uses ndisc_get_neigh from include/net/ndisc.h.

[ ip6t_ROUTE.c ]
rt->u.dst.neighbour = ndisc_get_neigh(rt->u.dst.dev, &rt->rt6i_dst.addr);


[ include/net/ndisc.h ]
static inline struct neighbour * ndisc_get_neigh(struct net_device *dev,
                                                 struct in6_addr *addr)
{
    if (dev)
        return __neigh_lookup(&nd_tbl, addr, dev, 1);
                               ^^^^^^ this symbol should be exported
                                      or this method should be reworked.

    return NULL;
}

--
/* Copyright (C) 2003, SCO, Inc. This is valuable Intellectual Property. */

                           #define say(x) lie(x)

-------------------------------------------------------

-- 
/* Copyright (C) 2003, SCO, Inc. This is valuable Intellectual Property. */

                           #define say(x) lie(x)

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2005-04-22 15:00 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-04-22 11:31 [PATCH] Warning: "nd_tbl" [net/ipv6/netfilter/ip6t_ROUTE.ko] undefined! Pawel Sikora
2005-04-22 11:59 ` YOSHIFUJI Hideaki / 吉藤英明
2005-04-22 12:07   ` YOSHIFUJI Hideaki / 吉藤英明
2005-04-22 15:00     ` Pawel Sikora

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.