From: Daniel Phillips <phillips@istop.com>
To: Nikita Danilov <nikita@clusterfs.com>
Cc: David Teigland <teigland@redhat.com>,
akpm@osdl.org,
Linux Kernel Mailing List <Linux-Kernel@Vger.Kernel.ORG>
Subject: Re: [PATCH 1b/7] dlm: core locking
Date: Mon, 25 Apr 2005 16:44:21 -0400 [thread overview]
Message-ID: <200504251644.21566.phillips@istop.com> (raw)
In-Reply-To: <17005.14407.228930.83593@gargle.gargle.HOWL>
Hi Nikita,
On Monday 25 April 2005 14:34, you wrote:
> > +
> > +static int is_remote(struct dlm_rsb *r)
> > +{
> > + DLM_ASSERT(r->res_nodeid >= 0, dlm_print_rsb(r););
> > + return r->res_nodeid ? TRUE : FALSE;
> > +}
>
> This can be simply
>
> return r->res_nodeid;
Not quite the same. Perhaps you meant:
return !!r->res_nodeid;
Regards,
Daniel
next prev parent reply other threads:[~2005-04-25 20:45 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-25 16:58 [PATCH 1b/7] dlm: core locking David Teigland
2005-04-25 18:34 ` Nikita Danilov
2005-04-25 20:44 ` Daniel Phillips [this message]
2005-04-25 22:27 ` Nikita Danilov
2005-04-26 1:34 ` Daniel Phillips
2005-04-25 20:41 ` Jesper Juhl
2005-04-26 5:00 ` Daniel Phillips
2005-04-25 21:54 ` Steven Dake
2005-04-26 5:49 ` David Teigland
2005-04-26 17:40 ` Steven Dake
2005-04-26 22:24 ` Daniel Phillips
2005-04-26 23:04 ` Steven Dake
2005-04-27 0:53 ` Daniel Phillips
2005-04-27 1:50 ` Steven Dake
2005-04-27 4:21 ` Daniel Phillips
2005-04-27 3:02 ` David Teigland
2005-04-27 13:41 ` Lars Marowsky-Bree
2005-04-27 14:26 ` David Teigland
2005-04-28 12:33 ` Lars Marowsky-Bree
2005-04-28 16:39 ` Daniel McNeil
2005-04-28 16:45 ` Lars Marowsky-Bree
2005-04-29 8:25 ` Daniel Phillips
2005-05-02 20:45 ` Lars Marowsky-Bree
2005-05-02 23:23 ` Daniel Phillips
2005-04-29 4:01 ` David Teigland
2005-04-29 22:58 ` Daniel McNeil
2005-04-30 4:29 ` David Teigland
2005-04-30 9:09 ` Daniel Phillips
2005-04-30 10:32 ` Lars Marowsky-Bree
2005-04-30 11:12 ` Daniel Phillips
2005-05-02 20:51 ` Lars Marowsky-Bree
2005-05-02 22:21 ` Daniel Phillips
2005-05-05 12:25 ` Stephen C. Tweedie
2005-05-05 12:40 ` copy_to_user question linux
2005-05-05 13:13 ` Richard B. Johnson
2005-05-05 19:29 ` [PATCH 1b/7] dlm: core locking Daniel Phillips
2005-04-28 2:52 ` Daniel Phillips
2005-04-28 12:37 ` Lars Marowsky-Bree
2005-04-28 23:43 ` Daniel Phillips
2005-04-28 6:49 ` Daniel Phillips
2005-04-28 12:55 ` Lars Marowsky-Bree
2005-04-29 0:26 ` Daniel Phillips
2005-04-29 2:52 ` David Teigland
2005-04-29 3:49 ` Daniel Phillips
2005-05-02 21:00 ` Lars Marowsky-Bree
2005-05-03 2:54 ` David Teigland
2005-04-27 12:33 ` Domen Puncer
2005-04-27 13:30 ` David Teigland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200504251644.21566.phillips@istop.com \
--to=phillips@istop.com \
--cc=Linux-Kernel@Vger.Kernel.ORG \
--cc=akpm@osdl.org \
--cc=nikita@clusterfs.com \
--cc=teigland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.