All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dtor_core@ameritech.net>
To: linux-kernel@vger.kernel.org, Greg KH <gregkh@suse.de>,
	Jean Delvare <khali@linux-fr.org>
Subject: [RFC/PATCH 0/5] read/write on attribute w/o show/store should return -ENOSYS
Date: Thu, 28 Apr 2005 00:30:09 -0500	[thread overview]
Message-ID: <200504280030.10214.dtor_core@ameritech.net> (raw)

Hi,

Jean Delvare has noticed that if a driver happens to declare its
attribute as RW but doesn't provide store() method attempt to write
into such attribute will cause spinning process as most of the
attribute implementations return 0 in case of missing store causing
endless retries. In some cases missing show/store will return -EPERM,
-EACCESS or -EINVAL.

I think we should unify implementations and have them all return -ENOSYS
(function not implemented) when corresponding method (show/store) is
missing.

-- 
Dmitry

             reply	other threads:[~2005-04-28  5:44 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-28  5:30 Dmitry Torokhov [this message]
2005-04-28  5:31 ` [RFC/PATCH 1/5] sysfs: if show/store is missing return -ENOSYS Dmitry Torokhov
2005-04-28  5:41 ` [RFC/PATCH 2/5] sysfs: (driver/base) " Dmitry Torokhov
2005-04-28  5:42 ` [RFC/PATCH 3/5] sysfs: (driver/pci) " Dmitry Torokhov
2005-04-28  5:43 ` [RFC/PATCH 4/5] sysfs: (driver/block) " Dmitry Torokhov
2005-04-28  5:44 ` [RFC/PATCH 5/5] sysfs: (rest) " Dmitry Torokhov
2005-04-28 17:26 ` [RFC/PATCH 0/5] read/write on attribute w/o show/store should " Greg KH
2005-04-28 17:37   ` Chris Wright
2005-04-28 17:44     ` Robert Love
2005-04-28 17:51     ` Dmitry Torokhov
2005-04-28 19:56       ` Richard B. Johnson
2005-04-28 20:08         ` Robert Love
2005-04-28 17:42   ` Robert Love
2005-04-29  6:22     ` [PATCH 1/5 (take 2)] sysfs: if show/store is missing return -EIO Dmitry Torokhov
2005-04-29  6:23       ` [PATCH 2/5 (take 2)] sysfs: (driver/base) " Dmitry Torokhov
2005-04-29  6:26       ` [PATCH 4/5 (take 2)] sysfs: (driver/block) " Dmitry Torokhov
2005-04-29  6:26       ` [PATCH 3/5 (take 2)] sysfs: (driver/pci) " Dmitry Torokhov
2005-04-29  6:27       ` [PATCH 5/5 (take 2)] sysfs: (rest) " Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200504280030.10214.dtor_core@ameritech.net \
    --to=dtor_core@ameritech.net \
    --cc=gregkh@suse.de \
    --cc=khali@linux-fr.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.