[-mm patch] kernel/irq/manage.c: remove the empty set_irq_info()

[-mm patch] kernel/irq/manage.c: remove the empty set_irq_info()

[Adrian Bunk]

I do still not like an empty global function.

All other cases are already handled by static inline's, so let's do the 
same with this one.

Signed-off-by: Adrian Bunk <bunk@stusta.de>

---

 include/linux/irq.h |    8 +++++++-
 kernel/irq/manage.c |    4 ----
 2 files changed, 7 insertions(+), 5 deletions(-)

--- linux-2.6.12-rc3-mm2-full/include/linux/irq.h.old	2005-05-01 14:55:16.000000000 +0200
+++ linux-2.6.12-rc3-mm2-full/include/linux/irq.h	2005-05-01 17:56:12.000000000 +0200
@@ -158,10 +158,16 @@
 	set_native_irq_info(irq, mask);
 }
 #endif // CONFIG_PCI_MSI
+
 #else
+
 #define move_irq(x)
 #define move_native_irq(x)
-extern void set_irq_info(unsigned int irq, cpumask_t mask);
+
+static inline void set_irq_info(int irq, cpumask_t mask)
+{
+}
+
 #endif // CONFIG_GENERIC_PENDING_IRQ
 
 extern int no_irq_affinity;
--- linux-2.6.12-rc3-mm2-full/kernel/irq/manage.c.old	2005-05-01 14:56:11.000000000 +0200
+++ linux-2.6.12-rc3-mm2-full/kernel/irq/manage.c	2005-05-01 14:56:24.000000000 +0200
@@ -40,10 +40,6 @@
 
 EXPORT_SYMBOL(synchronize_irq);
 
-#else
-void set_irq_info(unsigned int irq, cpumask_t mask)
-{
-}
 #endif
 
 /**

Re: [-mm patch] kernel/irq/manage.c: remove the empty set_irq_info()

[Zwane Mwaikambo]

On Sun, 1 May 2005, Adrian Bunk wrote:

> I do still not like an empty global function.
> 
> All other cases are already handled by static inline's, so let's do the 
> same with this one.
> 
> Signed-off-by: Adrian Bunk <bunk@stusta.de>

Acked-by: Zwane Mwaikambo <zwane@arm.linux.org.uk>

Thanks Adrian