[PATCH] compiling problem fixed

[PATCH] compiling problem fixed

[Martin Langer]

[-- Attachment #1: Type: text/plain, Size: 125 bytes --]

This fixes a 2.4 compiling problem on alpha. GFP_KERNEL was undeclared.

Signed-Off-by: Martin Langer <martin-langer@gmx.de>

[-- Attachment #2: adriver.patch --]
[-- Type: text/plain, Size: 309 bytes --]

--- include/adriver.h.ORIGINAL	2005-05-03 15:57:09.000000000 +0200
+++ include/adriver.h	2005-05-03 16:09:16.000000000 +0200
@@ -23,6 +23,7 @@
  */
 
 #include <linux/version.h>
+#include <linux/slab.h>
 
 #if LINUX_VERSION_CODE < KERNEL_VERSION(2, 2, 3)
 #error "This driver requires Linux 2.2.3 or higher."

Re: [PATCH] compiling problem fixed

[Takashi Iwai]

At Tue, 3 May 2005 16:29:16 +0200,
Martin Langer wrote:
> 
> [1  <text/plain; us-ascii (7bit)>]
> This fixes a 2.4 compiling problem on alpha. GFP_KERNEL was undeclared.
> 
> Signed-Off-by: Martin Langer <martin-langer@gmx.de>
> [2 adriver.patch <text/plain; us-ascii (7bit)>]
> --- include/adriver.h.ORIGINAL	2005-05-03 15:57:09.000000000 +0200
> +++ include/adriver.h	2005-05-03 16:09:16.000000000 +0200
> @@ -23,6 +23,7 @@
>   */
>  
>  #include <linux/version.h>
> +#include <linux/slab.h>
>  
>  #if LINUX_VERSION_CODE < KERNEL_VERSION(2, 2, 3)
>  #error "This driver requires Linux 2.2.3 or higher."

It's not nice to put to this place.  It always includes the file.

Where does this error happen?  In the gameport wrapper inline
function?  If so, try to include just before it so that it doesn't
affect to other kernel versions.


Takashi


-------------------------------------------------------
This SF.Net email is sponsored by Oracle Space Sweepstakes
Want to be the first software developer in space?
Enter now for the Oracle Space Sweepstakes!
http://ads.osdn.com/?ad_id=7393&alloc_id=16281&op=click

Re: [PATCH] compiling problem fixed

[Martin Langer]

[-- Attachment #1: Type: text/plain, Size: 860 bytes --]

On Wed, May 11, 2005 at 03:20:27PM +0200, Takashi Iwai wrote:
> At Tue, 3 May 2005 16:29:16 +0200,
> Martin Langer wrote:
> > 
> > This fixes a 2.4 compiling problem on alpha. GFP_KERNEL was undeclared.
> 
> It's not nice to put to this place.  It always includes the file.

Ah sorry, I see your point. Next time I should scroll down in my 
editor, before I create a patch :)

> Where does this error happen?  In the gameport wrapper inline
> function?  

Yep, it's in the gameport wrapper inline function. So now it's 
placed closer to that wrapper function.

---
Fix undeclared GFP_KERNEL in gameport wrapper inline function. Compile 
error happened with debian kernel 2.4.27 (alpha cpu).

Signed-off-by: Martin Langer <martin-langer@gmx.de>
---

BTW, the miroSOUND PCM12 with the new miro driver is running great, even 
on my alpha machine here :)


martin

[-- Attachment #2: adriver.patch --]
[-- Type: text/plain, Size: 318 bytes --]

--- include/adriver.h.ORIGINAL	2005-05-03 15:57:09.000000000 +0200
+++ include/adriver.h	2005-05-11 20:18:38.000000000 +0200
@@ -749,6 +749,7 @@
 #include <linux/gameport.h>
 #undef wait_ms
 #ifndef to_gameport_driver
+#include <linux/slab.h>
 /* old gameport interface */
 struct snd_gameport {
 	struct gameport gp;

Re: [PATCH] compiling problem fixed

[Takashi Iwai]

At Wed, 11 May 2005 20:54:59 +0200,
Martin Langer wrote:
> 
> On Wed, May 11, 2005 at 03:20:27PM +0200, Takashi Iwai wrote:
> > At Tue, 3 May 2005 16:29:16 +0200,
> > Martin Langer wrote:
> > > 
> > > This fixes a 2.4 compiling problem on alpha. GFP_KERNEL was undeclared.
> > 
> > It's not nice to put to this place.  It always includes the file.
> 
> Ah sorry, I see your point. Next time I should scroll down in my 
> editor, before I create a patch :)
> 
> > Where does this error happen?  In the gameport wrapper inline
> > function?  
> 
> Yep, it's in the gameport wrapper inline function. So now it's 
> placed closer to that wrapper function.

Thanks, applied now to CVS.


> 
> BTW, the miroSOUND PCM12 with the new miro driver is running great, even 
> on my alpha machine here :)

Good to hear ;)


ciao,

Takashi


-------------------------------------------------------
This SF.Net email is sponsored by Oracle Space Sweepstakes
Want to be the first software developer in space?
Enter now for the Oracle Space Sweepstakes!
http://ads.osdn.com/?ad_id=7393&alloc_id=16281&op=click