All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: Andrew Morton <akpm@osdl.org>
Cc: ak@suse.de, linux-kernel@vger.kernel.org
Subject: [2.6 patch] unexport phys_proc_id and cpu_core_id
Date: Fri, 6 May 2005 23:19:14 +0200	[thread overview]
Message-ID: <20050506211913.GO3590@stusta.de> (raw)

Back in January, Andi Kleen added EXPORT_SYMBOL(phys_proc_id), stating:
  This is needed for the powernow k8 driver to manage AMD dual core 
  systems.

This EXPORT_SYMBOL was never used.

I asked him on 13 Mar 2005 whether it's really required, but he didn't 
answer to my email.

2.6.12-rc3 adds cpu_core_id with a similarly unused 
EXPORT_SYMBOL(cpu_core_id).

It's OK to export symbols when these exports are required, but unless 
someone can explain why they are required now, they should be removed 
before 2.6.12 and then re-added when they are actually used.

Signed-off-by: Adrian Bunk <bunk@stusta.de>

---

 arch/i386/kernel/smpboot.c   |    2 --
 arch/x86_64/kernel/smpboot.c |    2 --
 2 files changed, 4 deletions(-)

--- linux-2.6.12-rc3-mm3-full/arch/i386/kernel/smpboot.c.old	2005-05-06 22:58:29.000000000 +0200
+++ linux-2.6.12-rc3-mm3-full/arch/i386/kernel/smpboot.c	2005-05-06 22:58:47.000000000 +0200
@@ -67,12 +67,10 @@
 /* Package ID of each logical CPU */
 int phys_proc_id[NR_CPUS] __cacheline_aligned_mostly_readonly =
 			{[0 ... NR_CPUS-1] = BAD_APICID};
-EXPORT_SYMBOL(phys_proc_id);
 
 /* Core ID of each logical CPU */
 int cpu_core_id[NR_CPUS] __cacheline_aligned_mostly_readonly =
 			{[0 ... NR_CPUS-1] = BAD_APICID};
-EXPORT_SYMBOL(cpu_core_id);
 
 cpumask_t cpu_sibling_map[NR_CPUS] __cacheline_aligned_mostly_readonly;
 cpumask_t cpu_core_map[NR_CPUS] __cacheline_aligned_mostly_readonly;
--- linux-2.6.12-rc3-mm3-full/arch/x86_64/kernel/smpboot.c.old	2005-05-06 22:59:01.000000000 +0200
+++ linux-2.6.12-rc3-mm3-full/arch/x86_64/kernel/smpboot.c	2005-05-06 22:59:12.000000000 +0200
@@ -67,8 +67,6 @@
 /* Package ID of each logical CPU */
 u8 phys_proc_id[NR_CPUS] = { [0 ... NR_CPUS-1] = BAD_APICID };
 u8 cpu_core_id[NR_CPUS] = { [0 ... NR_CPUS-1] = BAD_APICID };
-EXPORT_SYMBOL(phys_proc_id);
-EXPORT_SYMBOL(cpu_core_id);
 
 /* Bitmask of currently online CPUs */
 cpumask_t cpu_online_map;


             reply	other threads:[~2005-05-06 21:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-06 21:19 Adrian Bunk [this message]
2005-05-07 13:45 ` [2.6 patch] unexport phys_proc_id and cpu_core_id Andi Kleen
2005-06-02 20:48   ` Adrian Bunk
2005-06-02 21:12     ` Dave Jones
2005-07-09  3:07       ` Adrian Bunk
  -- strict thread matches above, loose matches on Subject: below --
2005-10-30 20:17 Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050506211913.GO3590@stusta.de \
    --to=bunk@stusta.de \
    --cc=ak@suse.de \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.