All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Clemens Ladisch <clemens@ladisch.de>
Cc: linux-hotplug-devel@lists.sourceforge.net,
	alsa-devel@lists.sourceforge.net
Subject: Re: [Alsa-devel] snd-usb-audio driver
Date: Tue, 10 May 2005 14:43:00 -0700	[thread overview]
Message-ID: <20050510214300.GA4292@kroah.com> (raw)
In-Reply-To: <Pine.HPX.4.33n.0505090919440.20877-100000@studcom.urz.uni-halle.de>

On Mon, May 09, 2005 at 09:41:19AM +0200, Clemens Ladisch wrote:
> Greg KH wrote:
> > On Fri, Apr 29, 2005 at 05:01:42PM -0400, David Zeuthen wrote:
> > > On Fri, 2005-04-29 at 13:09 -0700, Greg KH wrote:
> > > > You can do this, as you get two different hotplug events.  This is
> > > > because usb drivers bind to the USB inteface, not the main device
> > > > itself.
> > >
> > > As an unrelated note this is actually not true for snd-usb-audio driver
> > >
> > >         [davidz@daxter hal]$ ls -l /sys/class/sound/pcmC2D0c/
> > >         total 0
> > >         -r--r--r--  1 root root 4096 Apr 29 16:57 dev
> > >         lrwxrwxrwx  1 root root    0 Apr 29 16:57 device ->
> > > ../../../devices/pci0000:00/0000:00:1d.1/usb3/3-2
> >
> > This should point to the interface, not the device, you are correct.
> >
> > >         [davidz@daxter hal]$ tree /sys/bus/usb/drivers/snd-usb-audio/
> > >         /sys/bus/usb/drivers/snd-usb-audio/
> > >         |-- 3-2:1.0 -> ../../../../devices/pci0000:00/0000:00:1d.1/usb3/3-2/3-2:1.0
> > >         |-- 3-2:1.1 -> ../../../../devices/pci0000:00/0000:00:1d.1/usb3/3-2/3-2:1.1
> > >         |-- 3-2:1.2 -> ../../../../devices/pci0000:00/0000:00:1d.1/usb3/3-2/3-2:1.2
> > >         `-- module -> ../../../../module/snd_usb_audio
> > >
> > > That"s a bug, right? Is this the right place to report it?
> >
> > Bug in the alsa driver, I suggest reporting it to them.  Should be a one
> > line fix.
> 
> The ALSA framework currently has exactly one 'struct device' for all
> devices of a sound card.  If we want to bind to the respectively
> correct interface for each device we have to change more than one
> line.
> 
> I'll make a temporary fix to bind to the first interface that is
> probed.

That will not work a usb speaker device that has the first interface as
the usb keyboard :)

Why not just point the struct device for ALSA at the struct
usb_interface that is passed to you?  That's the proper one to use.

thanks,

greg k-h


-------------------------------------------------------
This SF.Net email is sponsored by Oracle Space Sweepstakes
Want to be the first software developer in space?
Enter now for the Oracle Space Sweepstakes!
http://ads.osdn.com/?ad_id=7393&alloc_id=16281&op=click

WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <greg@kroah.com>
To: Clemens Ladisch <clemens@ladisch.de>
Cc: linux-hotplug-devel@lists.sourceforge.net,
	alsa-devel@lists.sourceforge.net
Subject: Re: [Alsa-devel] snd-usb-audio driver
Date: Tue, 10 May 2005 21:43:00 +0000	[thread overview]
Message-ID: <20050510214300.GA4292@kroah.com> (raw)
In-Reply-To: <Pine.HPX.4.33n.0505090919440.20877-100000@studcom.urz.uni-halle.de>

On Mon, May 09, 2005 at 09:41:19AM +0200, Clemens Ladisch wrote:
> Greg KH wrote:
> > On Fri, Apr 29, 2005 at 05:01:42PM -0400, David Zeuthen wrote:
> > > On Fri, 2005-04-29 at 13:09 -0700, Greg KH wrote:
> > > > You can do this, as you get two different hotplug events.  This is
> > > > because usb drivers bind to the USB inteface, not the main device
> > > > itself.
> > >
> > > As an unrelated note this is actually not true for snd-usb-audio driver
> > >
> > >         [davidz@daxter hal]$ ls -l /sys/class/sound/pcmC2D0c/
> > >         total 0
> > >         -r--r--r--  1 root root 4096 Apr 29 16:57 dev
> > >         lrwxrwxrwx  1 root root    0 Apr 29 16:57 device ->
> > > ../../../devices/pci0000:00/0000:00:1d.1/usb3/3-2
> >
> > This should point to the interface, not the device, you are correct.
> >
> > >         [davidz@daxter hal]$ tree /sys/bus/usb/drivers/snd-usb-audio/
> > >         /sys/bus/usb/drivers/snd-usb-audio/
> > >         |-- 3-2:1.0 -> ../../../../devices/pci0000:00/0000:00:1d.1/usb3/3-2/3-2:1.0
> > >         |-- 3-2:1.1 -> ../../../../devices/pci0000:00/0000:00:1d.1/usb3/3-2/3-2:1.1
> > >         |-- 3-2:1.2 -> ../../../../devices/pci0000:00/0000:00:1d.1/usb3/3-2/3-2:1.2
> > >         `-- module -> ../../../../module/snd_usb_audio
> > >
> > > That"s a bug, right? Is this the right place to report it?
> >
> > Bug in the alsa driver, I suggest reporting it to them.  Should be a one
> > line fix.
> 
> The ALSA framework currently has exactly one 'struct device' for all
> devices of a sound card.  If we want to bind to the respectively
> correct interface for each device we have to change more than one
> line.
> 
> I'll make a temporary fix to bind to the first interface that is
> probed.

That will not work a usb speaker device that has the first interface as
the usb keyboard :)

Why not just point the struct device for ALSA at the struct
usb_interface that is passed to you?  That's the proper one to use.

thanks,

greg k-h


-------------------------------------------------------
This SF.Net email is sponsored by Oracle Space Sweepstakes
Want to be the first software developer in space?
Enter now for the Oracle Space Sweepstakes!
http://ads.osdn.com/?ad_ids93&alloc_id\x16281&op=click
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel

  reply	other threads:[~2005-05-10 21:43 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-09  7:41 [Alsa-devel] snd-usb-audio driver Clemens Ladisch
2005-05-09  7:41 ` Clemens Ladisch
2005-05-10 21:43 ` Greg KH [this message]
2005-05-10 21:43   ` Greg KH
2005-05-11  7:37   ` Clemens Ladisch
2005-05-11  7:37     ` Clemens Ladisch
2005-05-11  7:41     ` Greg KH
2005-05-11  7:41       ` [Alsa-devel] " Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050510214300.GA4292@kroah.com \
    --to=greg@kroah.com \
    --cc=alsa-devel@lists.sourceforge.net \
    --cc=clemens@ladisch.de \
    --cc=linux-hotplug-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.