Re: [PATCH] namespace.c: fix bind mount from foreign namespace

[Jamie Lokier <jamie@shareable.org>]

Miklos Szeredi wrote:
> +		if (ns1 < ns2) {
> +			down_write(&ns1->sem);
> +			down_write(&ns2->sem);
> +		} else {
> +			down_write(&ns2->sem);
> +			down_write(&ns1->sem);
> +		}

That's a bit smaller (source and compiled) as:

	if (ns2 < ns1)
		down_write(&ns2->sem);
	down_write(&ns1->sem);
	if (ns2 > ns1)
		down_write(&ns2->sem);

(And you'll notice that does the right thing if ns2==ns1 too, in case
that gives you any ideas.)

Otherwise, the patch looks convincing to me.

-- Jamie