[Ocfs2-devel] Re: [Ocfs2-commits] jlbec commits r2262 - branches/alloc_inode/fs/ocfs2

[Ocfs2-devel] Re: [Ocfs2-commits] jlbec commits r2262 - branches/alloc_inode/fs/ocfs2

[Christoph Hellwig]

On Tue, May 17, 2005 at 04:12:52PM -0500, svn-commits@oss.oracle.com wrote:
> Author: jlbec
> Date: 2005-05-17 16:12:51 -0500 (Tue, 17 May 2005)
> New Revision: 2262
> 
> Modified:
>    branches/alloc_inode/fs/ocfs2/aops.c
>    branches/alloc_inode/fs/ocfs2/file.c
>    branches/alloc_inode/fs/ocfs2/inode.c
>    branches/alloc_inode/fs/ocfs2/ocfs.h
> Log:
> 
> o Move ip_mmu_private to ocfs2_inode_info.

Btw, for many functions it would be a lot cleaner to have a local

struct ocfs2_inode_info *oi = OCFS2_I(inode);

at the beginning and the just use oi->foo.

[Ocfs2-devel] Re: [Ocfs2-commits] jlbec commits r2262 - branches/alloc_inode/fs/ocfs2

[Joel Becker]

On Tue, May 17, 2005 at 11:16:16PM +0200, Christoph Hellwig wrote:
> Btw, for many functions it would be a lot cleaner to have a local
> 
> struct ocfs2_inode_info *oi = OCFS2_I(inode);
> 
> at the beginning and the just use oi->foo.

	I do it when I see a bunch.  Right now, though, I'm not quite
ready to try and consolidate them, as they are in flux.

Joel

-- 

"Friends may come and go, but enemies accumulate." 
        - Thomas Jones

Joel Becker
Senior Member of Technical Staff
Oracle
E-mail: joel.becker@oracle.com
Phone: (650) 506-8127