From: Andi Kleen <ak@muc.de>
To: Matt Tolentino <metolent@snoqualmie.dp.intel.com>
Cc: akpm@osdl.org, apw@shadowen.org, haveblue@us.ibm.com,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [patch 4/4] add x86-64 specific support for sparsemem
Date: 18 May 2005 18:27:10 +0200
Date: Wed, 18 May 2005 18:27:10 +0200 [thread overview]
Message-ID: <20050518162710.GD88141@muc.de> (raw)
In-Reply-To: <200505181528.j4IFSTo1026925@snoqualmie.dp.intel.com>
> @@ -400,9 +401,12 @@ static __init void parse_cmdline_early (
> }
>
> #ifndef CONFIG_NUMA
> -static void __init contig_initmem_init(void)
> +static void __init
> +contig_initmem_init(unsigned long start_pfn, unsigned long end_pfn)
> {
> unsigned long bootmap_size, bootmap;
> +
> + memory_present(0, start_pfn, end_pfn);
Watch indentation.
Rest looks good.
-Andi
WARNING: multiple messages have this Message-ID (diff)
From: Andi Kleen <ak@muc.de>
To: Matt Tolentino <metolent@snoqualmie.dp.intel.com>
Cc: akpm@osdl.org, apw@shadowen.org, haveblue@us.ibm.com,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [patch 4/4] add x86-64 specific support for sparsemem
Date: 18 May 2005 18:27:10 +0200
Date: Wed, 18 May 2005 18:27:10 +0200 [thread overview]
Message-ID: <20050518162710.GD88141@muc.de> (raw)
In-Reply-To: <200505181528.j4IFSTo1026925@snoqualmie.dp.intel.com>
> @@ -400,9 +401,12 @@ static __init void parse_cmdline_early (
> }
>
> #ifndef CONFIG_NUMA
> -static void __init contig_initmem_init(void)
> +static void __init
> +contig_initmem_init(unsigned long start_pfn, unsigned long end_pfn)
> {
> unsigned long bootmap_size, bootmap;
> +
> + memory_present(0, start_pfn, end_pfn);
Watch indentation.
Rest looks good.
-Andi
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
next prev parent reply other threads:[~2005-05-18 16:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-18 15:28 [patch 4/4] add x86-64 specific support for sparsemem Matt Tolentino
2005-05-18 15:28 ` Matt Tolentino
2005-05-18 16:27 ` Andi Kleen [this message]
2005-05-18 16:27 ` Andi Kleen
-- strict thread matches above, loose matches on Subject: below --
2005-05-18 16:51 Matt Tolentino
2005-05-18 16:51 ` Matt Tolentino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050518162710.GD88141@muc.de \
--to=ak@muc.de \
--cc=akpm@osdl.org \
--cc=apw@shadowen.org \
--cc=haveblue@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=metolent@snoqualmie.dp.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.