All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: Mark Fasheh <mark.fasheh@oracle.com>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	ocfs2-devel@oss.oracle.com, torvalds@osdl.org, akpm@osdl.org,
	wim.coekaerts@oracle.com, lmb@suse.de
Subject: [Ocfs2-devel] Re: [RFC] [PATCH] OCFS2
Date: Wed May 18 19:56:34 2005	[thread overview]
Message-ID: <20050518234022.GA5112@stusta.de> (raw)
In-Reply-To: <20050518223303.GE1340@ca-server1.us.oracle.com>

On Wed, May 18, 2005 at 03:33:03PM -0700, Mark Fasheh wrote:
>...
> A full patch can be downloaded from:
> http://oss.oracle.com/projects/ocfs2/dist/files/patches/2.6.12-rc4/complete/ocfs2-configfs-all.patch
>...

Some comments on this patch:
- there's no reason to make JBD user-visible
- is there any reason why CONFIGFS_FS is user-visible?
- some global code might become static:
  run "make namespacecheck" after compiling the kernel and check
  the configfs and ocfs2 parts of the output

> Mark Fasheh

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

WARNING: multiple messages have this Message-ID (diff)
From: Adrian Bunk <bunk@stusta.de>
To: Mark Fasheh <mark.fasheh@oracle.com>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	ocfs2-devel@oss.oracle.com, torvalds@osdl.org, akpm@osdl.org,
	wim.coekaerts@oracle.com, lmb@suse.de
Subject: Re: [RFC] [PATCH] OCFS2
Date: Thu, 19 May 2005 01:40:22 +0200	[thread overview]
Message-ID: <20050518234022.GA5112@stusta.de> (raw)
In-Reply-To: <20050518223303.GE1340@ca-server1.us.oracle.com>

On Wed, May 18, 2005 at 03:33:03PM -0700, Mark Fasheh wrote:
>...
> A full patch can be downloaded from:
> http://oss.oracle.com/projects/ocfs2/dist/files/patches/2.6.12-rc4/complete/ocfs2-configfs-all.patch
>...

Some comments on this patch:
- there's no reason to make JBD user-visible
- is there any reason why CONFIGFS_FS is user-visible?
- some global code might become static:
  run "make namespacecheck" after compiling the kernel and check
  the configfs and ocfs2 parts of the output

> Mark Fasheh

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


  parent reply	other threads:[~2005-05-18 19:56 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-18 17:33 [Ocfs2-devel] [RFC] [PATCH] OCFS2 Mark Fasheh
2005-05-18 22:33 ` Mark Fasheh
2005-05-18 19:56 ` [Ocfs2-devel] " Hans Reiser
2005-05-18 23:35   ` Hans Reiser
2005-05-18 19:56 ` Adrian Bunk [this message]
2005-05-18 23:40   ` Adrian Bunk
2005-05-18 20:26   ` [Ocfs2-devel] " Manish Singh
2005-05-19  1:26     ` Manish Singh
2005-05-19  4:59     ` Adrian Bunk
2005-05-19  9:45       ` Adrian Bunk
2005-05-19 10:24       ` 2.4 kernel threads linux
2005-05-19 10:39         ` Arjan van de Ven
2005-05-19 16:19         ` Jesse Barnes
2005-05-18 23:28 ` [Ocfs2-devel] Re: [RFC] [PATCH] OCFS2 Kyle Moffett
2005-05-19  2:30   ` Kyle Moffett
2005-05-18 23:30   ` [Ocfs2-devel] " Mark Fasheh
2005-05-19  4:30     ` Mark Fasheh
2005-05-19  1:52 ` [Ocfs2-devel] " Daniel Phillips
2005-05-19  6:30   ` Daniel Phillips
2005-05-19  1:54   ` [Ocfs2-devel] " Mark Fasheh
2005-05-19  6:54     ` Mark Fasheh
2005-05-19 11:19     ` [Ocfs2-devel] " Daniel Phillips
2005-05-19 16:23       ` Daniel Phillips
2005-05-19 10:26   ` Jeff Garzik
2005-05-19 15:09     ` [Ocfs2-devel] " Jeff Garzik
2005-05-19 15:09     ` Lee Revell
2005-05-19 15:20       ` Lee Revell
2005-05-19 15:09       ` [Ocfs2-devel] " Jeff Garzik
2005-05-19 15:25         ` Jeff Garzik
2005-06-23 13:03 ` [Ocfs2-devel] " James Morris
2005-06-23 18:03   ` James Morris
2005-06-23 13:29   ` [Ocfs2-devel] " Mark Fasheh
2005-06-23 18:29     ` Mark Fasheh
2005-06-24  3:05   ` Paul Jackson
2005-06-24 15:34     ` [Ocfs2-devel] " Paul Jackson
2005-06-23 23:00     ` Mark Fasheh
2005-06-24  3:59       ` Mark Fasheh
2005-06-24  4:17       ` Paul Jackson
2005-06-24 15:34         ` [Ocfs2-devel] " Paul Jackson
2005-06-24  3:29     ` Paul Jackson
2005-06-24 15:34       ` [Ocfs2-devel] " Paul Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050518234022.GA5112@stusta.de \
    --to=bunk@stusta.de \
    --cc=akpm@osdl.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lmb@suse.de \
    --cc=mark.fasheh@oracle.com \
    --cc=ocfs2-devel@oss.oracle.com \
    --cc=torvalds@osdl.org \
    --cc=wim.coekaerts@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.